rmannibucau commented on PR #1271: URL: https://github.com/apache/poi/pull/1271#issuecomment-5745793033
yes and no, before entering into more details I'd like another PMC optinion since formula are generally a big criteria to import POI in a project (the other one being to read xls(x) files but really not the only one. now the benchmark is ultra relevant for documents: there is no valid reason it is not as fast for HSS and XSS for most cases (edge ones where it can be valid is bloated sheets - not common, cross workbook docs - acceptable), so at some point I think this PR could be the base for the HSS and XSS impl which would be a 2 ways sync instead of using storage as in memory computation model (and please don't change it on trunk right now as the changes you did yesterday which overlapped with this PR after you reviewed it, i'd prefer to converge even with multiple iteration/commits/PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
