pjfanning opened a new pull request, #1315:
URL: https://github.com/apache/poi/pull/1315
Follow-up to the recent test PRs: the three remaining
`assertTrue`/`assertFalse` calls that wrap a `String.contains(...)` or
`isEmpty()` now use Hamcrest matchers, so a failure shows the string that was
inspected instead of just `expected: <true> but was: <false>`.
- `TestXWPFRun.addChartEscapesRelationshipId`: `assertThat(xml,
not(containsString("<evil>")))` and `assertThat(..., containsString("rId42"))`
- `XSSFSharedFormulaFixture.assertSharedFormulas`:
`assertThat(f.getStringValue(), not(emptyString()))`
Test-only change; `TestXWPFRun` (46) and
`TestXSSFFormulaEvaluatorCacheNotificationSharedFormulas` (18) pass locally.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
