pjfanning opened a new pull request, #126:
URL: https://github.com/apache/poi-xmlbeans/pull/126
Moves the baseline from Java 8 to Java 17 and adopts Java 17 language idioms
in `src/main`.
### Build
- `build.gradle`: source/target 17, default `jdkVersion` 17; `compileJava9`
(module-info) also compiles at 17, since a release-9 compile cannot read Java
17 class files; javadoc uses source 17 and links the Java 17 API docs.
- Removed `targetCompatibility = ...14` from the `forbiddenApis { }` block.
It was resolving to the project property and pinning every compile to target
14, which fails with source 17. forbiddenApis now follows the project target.
- `build.xml`: `release` and `jdk.version.*` set to 17.
- `xkit/README.txt`: minimum JDK is now 17.
### Code
- About 150 check-then-cast `instanceof` sites converted to pattern matching
(`instanceof Foo foo`), mostly via OpenRewrite's `InstanceOfPatternMatch`, then
hand-tidied (binding names, leftover blank lines). Two sites kept their casts
where a binding read worse (`CharUtil` reusing `j`, `Locale` assigning `chars`
on both branches).
- Language features only, no new JDK APIs: the Android API 26 animalsniffer
signature check still passes.
- No text blocks, `var`, records or switch-statement rewrites in this PR.
### Verification
`./gradlew check javadoc jar -x rat` passes locally on JDK 17 (3194 tests, 0
failures). `rat` was skipped only because of untracked local IDE directories.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
