pjfanning opened a new pull request, #1373: URL: https://github.com/apache/poi/pull/1373
SpotBugs flags these messages: each one is built inside a null check and prints the value that was just found to be `null` (NP_LOAD_OF_KNOWN_NULL_VALUE). This PR only changes message text; no exception types or code paths change. | Where | Before | After | |---|---|---| | `AgileEncryptionHeader` | `Invalid hash size: null` | `Missing hash size in the key data` | | `FormulaParser.parseStructuredReference` (one column) | `Cannot parse column: null with formula …` | `Cannot parse column: missing column name in formula …` | | XDGF `Ellipse` | `Invalid cell 'null' in Ellipse row` | `Cell without a name in Ellipse row` | | `PackageRelationshipCollection.getRelationshipByID` | `… provided ID is empty: null, having relationships: …` | `… no ID provided, having relationships: …` | | HWMF `WmfDibCreatePatternBrush` | `Could not read color-usage null` | `Could not read color-usage <value read>` | The HWMF message printed the enum lookup that had failed; it now prints the raw value read from the file, which is what's useful when investigating. No tests assert on these messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
