pjfanning opened a new pull request, #1372: URL: https://github.com/apache/poi/pull/1372
`XSSFBEventBasedExcelExtractor.setHandleHyperlinksInCells(true)` has had no effect since XLSB support was added. `getText()` built each sheet's `XSSFBHyperlinksTable` but never used it (SpotBugs: dead store to `hyperlinksTable`). With the option on, the text of a cell covered by a hyperlink now gets ` <target>` appended. That is the same form `XWPFWordExtractor.setFetchHyperlinks` uses for linked text. The target is the url for external links, and the location (e.g. `Sheet2!A1`) for links within the workbook. For example, `hyperlink.xlsb` gives: ``` http://tika.apache.org <http://tika.apache.org/> ``` The option defaults to `false`, so the output only changes for callers that already set it. The setter now has javadoc describing the format. The change is limited to the extractor: a private handler wraps the sheet's text handler only when the option is on and the sheet has hyperlinks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
