pjfanning opened a new pull request, #1375: URL: https://github.com/apache/poi/pull/1375
`IOUtils.skipFully` allocated a 2 KB throwaway buffer on every call. Most callers skip only a few bytes: HPSF padding, the 2-byte skip in `HemfFont`, and short picture headers in HSLF. The buffer is now `min(toSkip, 2048)` bytes. Unchanged: - It still reads rather than calling `skip()` (IO-203). - It still uses its own buffer per call. The existing comment explains why the buffer isn't shared between threads. - It still returns -1 when nothing could be skipped. That is documented and `VBAMacroReader` relies on it. A new test checks that a 3-byte skip only asks the stream for 3 bytes, and covers the partial skip and the -1 at the end of the stream. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
