pjfanning opened a new pull request, #1393: URL: https://github.com/apache/poi/pull/1393
Follow-up to #1392. - `getPropertyGUID` and `getStreamID` dereferenced `guidStream.getValue()` / `stringStream.getValue()` without a null check, so a recorded `ByteChunk` with no value made `getPropertyTag` throw `NullPointerException`. A missing value is now treated like an empty stream: string named lookups and GUID-stream property sets return 0, and numerical named lookups are unaffected. - `testEmptyNameAtEndOfStringStream` now resolves the empty name through a stream entry (tag `0x8007`), so it verifies the boundary read actually works rather than only that `"Test"` isn't found. - New `testHighNumericalPropertyId` covers numerical named IDs ≥ `0x80000000`, whose stream ID #1392 fixed as a side effect by widening `nameOffset` to `long` (previously the `int` remainder went negative and the lookup missed). The two new null tests fail with NPE on current trunk. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
