aizu-m opened a new pull request, #136:
URL: https://github.com/apache/poi-xmlbeans/pull/136
Saving text that trips the CDATA heuristic (more than 32 chars and more than
5 `<`/`&`) with a C0 control in the first or second position:
XmlObject xo = XmlObject.Factory.newInstance();
try (XmlCursor c = xo.newCursor()) {
c.toNextToken();
c.insertElementWithText("a",
"\u0001<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<");
}
XmlObject.Factory.parse(xo.xmlText());
error: An invalid XML character (Unicode: 0x1) was found in the CDATA
section.
The CDATA branch of `TextSaver.entitizeContent` splices the first character
into `<![CDATA[`, reads the second one only to seed the `]]>` tracking, and
starts its `isBadChar` loop at the third. So the first two characters are
written raw, while the same character at position three or later becomes `?`,
as it does in the non-CDATA branch. The fix replaces a bad first character in
the prefix and starts the loop at the second character. The buffer wrap check
now also runs before that read, not after it. Valid text saves exactly as
before.
Added `CDataTest.badCharInCData` for positions 0, 1 and 2. Positions 0 and 1
fail without the fix. `./gradlew test` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
