pjfanning opened a new pull request, #1434: URL: https://github.com/apache/poi/pull/1434
Follow-up to #1430 / #1431 (bug 66263): two more places where `XWPFWordExtractor` dropped text. **Runs inside hyperlinks, simple fields, smart tags and custom XML runs in an inline SDT.** `XWPFSDTContent(CTSdtContentRun, …)` only took `w:r` and nested `w:sdt`, so a content control containing a hyperlink lost the link text. It now reads these the way `XWPFParagraph` does for its own runs: `XWPFHyperlinkRun` and `XWPFFieldRun` for hyperlinks and fields, and it looks inside smart tags and custom XML runs. **Cells wrapped in `w:customXml`.** `XWPFTableRow.getTableICells()` only returned `w:tc` and `w:sdt` cells. Cells inside a custom XML cell are now included, however deeply nested. `getTableCells()` is unchanged. `CTCustomXmlCellImpl` is added to the `poi-ooxml-lite` report. Body-level `w:customXml` blocks are still not read. Making them visible in `getBodyElements()`/`getParagraphs()` would also mean reworking the index-based remove/set methods in seven containers, and Word has not supported custom XML markup since 2010. Tests: `TestXWPFSDT.testInlineSdtWithWrappedRuns`, `TestXWPFTableRow.testTableICellsIncludeCustomXmlCells`, `TestXWPFWordExtractor.testCustomXmlCellsAndWrappedRunsInSdt`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
