tballison commented on code in PR #1473:
URL: https://github.com/apache/poi/pull/1473#discussion_r4377145666
##########
poi/src/main/java/org/apache/poi/ss/usermodel/DataFormatter.java:
##########
@@ -555,7 +555,10 @@ protected Format createFormat(double cellValue, int
formatIndex, String sFormat)
if (plainFraction || fractionWithText) {
if (fractionWithText) {
try {
- return new
CellFormatWrapper(CellFormat.getInstance(locale, formatStr));
+ CellFormat cellFormat = CellFormat.getInstance(locale,
formatStr);
+ // a format CellFormat cannot make sense of fails here,
not when formatting
Review Comment:
Kept, and updated the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
