pjfanning commented on code in PR #1570:
URL: https://github.com/apache/poi/pull/1570#discussion_r4648072704


##########
poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java:
##########
@@ -461,6 +461,28 @@ void testGetSheetDrawingParts() throws Exception {
         }
     }
 
+    @Test
+    void testDrawingTargetedByDuplicateRelationships() throws Exception {
+        try (OPCPackage pkg = 
XSSFTestDataSamples.openSamplePackage("WithTextBox.xlsx")) {

Review Comment:
   Could the test also cover a duplicate-`<sheet>` workbook and an 
external/invalid drawing target alongside a valid one (see the inline comments)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to