naruto-lgtm commented on PR #1580:
URL: https://github.com/apache/poi/pull/1580#issuecomment-7059262687

   Pushed 40bc4b8 with the inline points addressed, plus the two outside the 
diff:
   
   Cached comment: the removed row's cells now get their cached `_comment` 
cleared, through a package-private `HSSFCell.clearCachedComment()` rather than 
`removeCellComment()`, so it costs nothing and doesn't pull the drawing in. 
`removeRowRemovesComments` asserts `getCellComment()` on the removed cell comes 
back null.
   
   Javadoc: `removeRow` now says the row's cell comments are removed as well, 
with a line that they used to survive and be written out again, so code that 
needs them has to read them before removing the row.
   
   The whole `org.apache.poi.hssf` suite passes (4176 tests). 
`TestDateSerialRange.testEdgesOfTheRange` fails in the `ss` package, but it 
fails the same way on an unpatched trunk, so it's unrelated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to