naruto-lgtm commented on PR #1582:
URL: https://github.com/apache/poi/pull/1582#issuecomment-7059327034

   Took the pass-through option, so neither index is involved: read() keeps the 
part it is creating and the relationship it found it by, and 
getPackageRelationship returns that. PackageRelationshipCollection is left 
alone. Its internalRelationshipsByTargetName has different semantics 
(unresolved target, case-sensitive, last-wins) and findExistingRelation callers 
depend on them, so reworking it for this didn't seem worth the blast radius.
   
   That also removes the finally-only reset, the external relationships being 
resolved, the swallowed IllegalArgumentException and the liveness check, all of 
which you flagged inline.
   
   Test: no wall-clock timeout, 50 child parts and 2,000 external relationships 
instead of 900/50,000, and it now asserts which relationship each child part 
was mapped to. One thing to be aware of: without the timeout the quadratic path 
isn't guarded by the test any more, only the mapping is. The 980-part, 
100,000-relationship file still loads in about a second here against about 24 s 
on trunk.
   
   :poi-ooxml:test passes apart from two autosize/column-width tests that fail 
the same way on trunk on this machine (font metrics).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to