The GitHub Actions job "Java CI with Ant" on poi.git/trunk has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
49c720c76ec1e2db98298ca09cc9c2eb41b1c7bc / Nayyar <[email protected]>
SignaturePart: reject a package manifest moved into another element (#1581)

* SignaturePart: reject a package manifest moved into another element

* SignaturePart: key the manifest check on the signed references

Drive the check from the SignedInfo references and xmlSignature.getObjects()
instead of scanning the part for ds:Manifest elements, so a manifest the
SignedInfo never references, e.g. in unsigned XAdES properties, is left alone,
and name the offending element and Id in the warning.

Also reject a duplicate Id in the signature part, so that the getElementById
lookups in hasSignedRelationships can't resolve to an element other than the
one the digest was taken over. The fragment resolver already refuses the
ambiguous reference, but by throwing, which validate() turns into an
EncryptedDocumentException rather than a false.

The test does the edit on the signature DOM rather than by splicing strings,
and adds the untampered wrapping, which pins the new check, and the duplicate
Id case.

Report URL: https://github.com/apache/poi/actions/runs/44894545446

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to