rdblue commented on code in PR #174:
URL: https://github.com/apache/polaris/pull/174#discussion_r1725799896


##########
NOTICE:
##########
@@ -1,5 +1,5 @@
-Polaris
-Copyright 2024 Snowflake Computing Inc.
+Apache Polaris (incubating)
+Copyright 2024 The Apache Software Foundation

Review Comment:
   This PR replaces copyright headers that credit Snowflake with the standard 
ASF header. When we do that, I think [ASF 
policy](https://www.apache.org/legal/src-headers.html#headers) requires that 
someone from the company that is donating submit or approve the header changes. 
Here's the specific guidance:
   
   > 1. If the source file is submitted with a copyright notice included in it, 
the copyright owner (or owner's agent) must either:
   >     a. remove such notices, or
   >     b. move them to the NOTICE file associated with each applicable 
project release, or
   >     c. provide written permission for the ASF to make such removal or 
relocation of the notices.
   
   What I've done in the past is had someone from the donating company approve 
the PR and taken option b to relocate the copyright header to NOTICE 
([example](https://github.com/apache/iceberg/blob/main/NOTICE#L10-L25)). That 
is usually an easy solution, but it does have a downside that it adds NOTICE 
content that has to be included in downstream NOTICE files. When we donated 
Iceberg, I was working for Netflix and removed the headers so we didn't need to 
include it in NOTICE.
   
   Also, the NOTICE below about Apache Iceberg is no longer required for ASF, 
and was specifically discouraged by Roy in a comment. It's fine to keep it, but 
you may want to remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to