Thanks for this proposal, Mike!

I made some comments on the doc.

Would you mind adding a diagram with CDI scopes and interface instances
(i.e. whether a particular object implements one or more interfaces)? As
for me personally, it would be very helpful for understanding runtime
implications better. The existing diagram, while giving some ideas about
service relationships, still looks somewhat detached from actual code.

How would you like to go about specific interface changes? Would you like
to have pseudo-code in the doc or open a PR for a more nitty-gritty
discussion? I'd be fine either way, but I think a discussion of API
specifics would be valuable (with respect to my API skew comments in #465
[1]).

Thanks,
Dmitri.

[1] https://github.com/apache/polaris/pull/465

On Tue, Dec 10, 2024 at 7:38 PM Michael Collado <collado.m...@gmail.com>
wrote:

> Hey folks
>
> We've talked about breaking up the metastore interface and better
> encapsulating the various areas of responsibility. I think there are some
> competing thoughts around what should be handled by the different
> interfaces, so I created https://github.com/apache/polaris/issues/526 to
> try to capture the goals we all have around better OO design.
>
> I also linked a doc where I described both the current state of things as
> well as where I think we should be heading. It includes some proposed
> interface changes and redesign of the component architecture.
>
>
> https://docs.google.com/document/d/1MNCdW-uKVZaR5Ua91FDwxhreBeGjPOoV-CyF0WOWwIg/edit?tab=t.0
>
> Please comment on the github issue and/or the Google doc (I think everyone
> should have privileges).
>
> Mike
>

Reply via email to