+1 (non-binding). The source distro looks good to me. There is a lot of work to do before we're ready for the binary distribution, but I don't think that should block this first source distro.
Mike On Tue, Jan 14, 2025 at 1:19 AM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > +1 (binding) > > As this release includes only source distribution, it's fine because: > - hash and signature are OK > - incubating is in the name/version > - DISCLAIMER_WIP is there > - LICENSE is OK, including note about Apache licensed third-party > components (e.g. gradle). We can optionally mention > PolarisRestCatalogIntegrationTest.java here (copied from Apache > Iceberg TestRESTCatalog.java), but it's not strictly required and not > a release blocker. > - NOTICE is OK because: > a. It includes the copyright > b. It mentions projects included (strictly speaking, it should be > only projects we copy code from, but we are free to mention projects > we use) > c. It mentions the code donation > d. It includes (copy) NOTICE from projects used (strictly speaking, > it should be only projects we copy code from, but we are free to > mention projects we use). For instance, DropWizard provides a NOTICE > file (https://github.com/dropwizard/dropwizard/blob/release/4.0.x/NOTICE) > which is copied into our NOTICE. > - LICENSE-BINARY-DIST is not relevant for this release as we don't > distribute binary packages, only the source package. The > LICENSE-BINARY-DIST has to be fixed later, for the first release that > will include binary packages (1.0.0). > - No binary files found in the source distribution > - ASF header is present in all expected files > > For LICENSE-BINARY-DIST, I see several issues: > 1. It has multiple copies of the same license, things are not grouped > by license, and there are incompatible licenses in there. One way to > improve this would be to list them by group, and create licenses > directly and put each license in a separate file in that (see > https://github.com/apache/gravitino/tree/main/licenses for instance) > 2. It confuses what is bundled and what is dependency. I see some test > libs in there that I would not expect to be bundled or used at > runtime. > 3. The gradle "task" checking/generating the LICENSE-BINARY-DIST is > probably missing a lot of licenses as they often have different names > like "COPYING", "LICENSE.txt", "LICENSE.md", ... > I'm not convinced it's a good idea to use gradle "task" for > LICENSE-BINARY-DIST. However, as we are changing the runtime > dependencies (replacing DropWizard by Quarkus), a complete pass is > needed on LICENSE-BINARY-DIST anyway. > > Regards > JB > > On Wed, Jan 8, 2025 at 5:00 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > > Hi folks, > > > > As mentioned in another thread, I submit Apache Polaris > > 0.9.0-incubating rc2 to your vote. > > > > * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc2 > > * > https://github.com/apache/polaris/commits/apache-polaris-0.9.0-incubating-rc2 > > * > https://github.com/apache/polaris/tree/8289d4e340343f737fade4ee7e20136fe7c8a9ec > > > > The release tarball, signature, and checksums are here: > > * > https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0-incubating/ > > > > You can find the KEYS file here: > > * https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS > > > > NB: as we are still working on the binary distributions, this release > > "only" includes the source distribution (mandatory by The ASF and The > > ASF Incubator). > > > > Please download, verify, and test. > > > > Please vote in the next 72 hours. > > [ ] +1 Release this as Apache polaris 0.9.0-incubating > > [ ] +0 > > [ ] -1 Do not release this because... > > > > Only PPMC members and mentors have binding votes, but other community > > members are encouraged to cast non-binding votes. This vote will pass > > if there are > > 3 binding +1 votes and more binding +1 votes than -1 votes. > > > > NB: if this vote passes, a new vote will be started on the Incubator > > general mailing list. > > > > Thanks > > Regards > > JB >
