I also noticed Yufei's comment re: the health checker endpoint, which is now gone. Is there an issue to address that as well? I think we ought to treat the admin endpoints (/healthcheck and /metrics) just as we would treat the management or catalog APIs - that is to say, we wouldn't simply remove one of those APIs without deprecating and giving users the opportunity to migrate.
Mike On Tue, Jan 14, 2025 at 5:16 AM Alex Dutra <alex.du...@dremio.com.invalid> wrote: > Hi all, > > The Quarkus PR has finally been merged today! I would like to thank all of > you who spend time reviewing and testing this. > > A few follow up PRs were merged too. Please take some time to walk through > the new code; JB, Robert, Dmitri and I are available to answer any > questions and also to help rebase your PRs. > > *Please note though, that as of now, the Docker images, the Helm chart and > the documentation are still out of sync.* > > We still need to get the following PRs in to fix this gap: > > - Docker images: https://github.com/apache/polaris/pull/610 > - Helm chart: https://github.com/apache/polaris/pull/626 > - Documentation: https://github.com/apache/polaris/pull/700 > > Once they are in, we can consider the migration to Quarkus as fully > achieved. > > Thanks! > > Alex > > On Thu, Jan 2, 2025 at 6:15 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > Hi Alex, > > > > It sounds good. And I agree. > > > > I'm happy to include Quarkus merge for 0.9.0 (rc2), that makes perfect > > sense to me and open the path for the next releases without "user > > facing change". That said, it means I have to do a new pass on the > > LICENSE (especially for the binary distributions) and NOTICE. As we > > are not in the rush about rc2 (we agreed to do rc2 in the coming > > weeks). > > > > Let's just give the time to the community to be back from "festive > break". > > > > Regards > > JB > > > > On Tue, Dec 31, 2024 at 2:32 PM Alex Dutra > > <alex.du...@dremio.com.invalid> wrote: > > > > > > Hi all, > > > > > > I hope everyone is having a great holiday season so far! > > > > > > Unless I'm mistaken, I think we have an agreement to move forward with > > the > > > switch to Quarkus. I'm wondering when we should merge it? Keeping such > a > > large > > > PR open for too long is not ideal, but I also don't want to rush it. > > > > > > Here 's some useful context to help us decide: > > > > > > The PR has been up for review for a few weeks now, and I encourage > > everyone to > > > take a look at it: : https://github.com/apache/polaris/pull/469. > > > > > > See also the proposal document: > > > > > > > > > https://docs.google.com/document/d/1C7E0ma6OvHGvWMJlZVkQHBsvPg8Pe9aroDtQ_79SIXY/edit > > > > > > Luckily, the changes are not too invasive for most modules – except for > > the > > > Dropwizard runtime module, of course. People can continue working on > > modules > > > like core, api, persistence, service-common, etc. without much trouble. > > > > > > OTOH, merging soon-ish would settle the dust, and we could start > > focusing more > > > on the new features that we have planned for the next releases. > > > > > > Merging would also unlock a few other PRs that are waiting on the > Quarkus > > > switch: > > > > > > - https://github.com/apache/polaris/pull/589 (follow-up to the Quarkus > > PR) > > > - https://github.com/apache/polaris/pull/592 (follow-up to the Quarkus > > PR) > > > - https://github.com/apache/polaris/pull/594 (fixes a sensitive issue) > > > > > > I looked briefly at all the outstanding PRs, and I think that the only > > one that > > > might be affected significantly by the switch to Quarkus is the one > that > > > refactors the integration tests: > > > > > > https://github.com/apache/polaris/pull/590 > > > > > > In fact, it might be a good idea to merge that one first, since it > would > > > somewhat simplify the Quarkus PR itself. That's up for discussion, > > though. It > > > could be merged after as well. > > > > > > Also, Mike's PR that refactors PolarisAuthorizerImpl would be affected, > > albeit > > > in a lesser proportion, by the switch to Quarkus: > > > > > > https://github.com/apache/polaris/pull/465 > > > > > > I personally think that the changes in that PR are not too difficult to > > merge > > > after the switch, and I could help with that. But again, that's up for > > > discussion. > > > > > > Merging the Quarkus PR won't be "the end of the road" for the Quarkus > > switch. > > > There are still a few things that we need to do immediately after, > like: > > > > > > - Adapting the documentation > > > - Adapting the Docker images > > > - Adapting the Helm chart > > > - Communicating the change to the community > > > > > > All of these are on my TODO list with high priority. > > > > > > And finally, I wanted to mention that the switch in overall aims to be > as > > > seamless as possible for users and operators of Polaris, but a few > > things will > > > change, and we need to be prepared for that: > > > > > > - The configuration file will have a new format > > > - Cross-cutting concerns like logging, metrics, and tracing will have > > different > > > shapes, names, etc. > > > > > > These are noted in the proposal document, but I wanted to mention them > > here as > > > well so that everyone is aware. > > > > > > I am hoping that the switch could be included in the next release, > 0.9.0, > > > somewhere in January 2025. I'm looking forward to hearing your thoughts > > on this. > > > > > > I wish you all a great New Year's Eve and a happy New Year! > > > > > > Best regards, > > > > > > Alex > > >
