Hi Russ thanks for the review. Let me do a pass, the cherry-pick on the branch is not maybe fully correct.
I'm checking, thanks ! Regards JB On Tue, Jan 21, 2025 at 9:01 PM Russell Spitzer <russell.spit...@gmail.com> wrote: > > Let me actually link things properly, > > RC3 - aaf5d42 > <https://github.com/apache/polaris/commit/aaf5d42b1959fd8d2bf617fdbe6dcf7e5b9a1eca> > > Main - 4187721 > <https://github.com/apache/polaris/commit/4187721e24717dd266fb147f0ca167e1a108a995> > > Looks like the RC3 Commit is just missing the fix to the list truncation. > Other than that the net changes seem similar but slightly less lines are > removed. > > JB could you take another pass to make sure? > > Thanks for fixing all this up, I know licensing is difficult > Russ > > > > On Tue, Jan 21, 2025 at 1:56 PM Dmitri Bourlatchkov > <dmitri.bourlatch...@dremio.com.invalid> wrote: > > > Hmmm, for reference I only compiled production code in my tests. > > > > On Tue, Jan 21, 2025 at 2:52 PM Russell Spitzer <russell.spit...@gmail.com > > > > > wrote: > > > > > -1 > > > > > > > Task :polaris-version:compileJarTestJava FAILED > > > > > /Users/rspitzer/ValidateRelease/apache-polaris-0.9.0-incubating/tools/version/src/jarTest/java/org/apache/polaris/version/TestPolarisVersion.java:113: > > > error: illegal start of expression > > > } > > > ^ > > > > > > > > > Patch attached > > > > > > On Tue, Jan 21, 2025 at 1:19 PM Dmitri Bourlatchkov > > > <dmitri.bourlatch...@dremio.com.invalid> wrote: > > > > > >> +1 (nb) > > >> > > >> Validated checksum, signature and local build with JDK 21. Ran and > > >> smoke-tested by creating a catalog via ./polaris CLI. > > >> > > >> Note: I did observe some WARN log messages from HK2, but I do not think > > >> those are blockers for this release. > > >> > > >> Cheers, > > >> Dmitri. > > >> > > >> On Mon, Jan 20, 2025 at 2:32 AM Jean-Baptiste Onofré <j...@nanthrax.net> > > >> wrote: > > >> > > >> > Hi folks, > > >> > > > >> > Following the rc2 vote, we fixed NOTICE/LICENSE for the source > > >> > distribution. > > >> > > > >> > This is the vote for Apache Polaris 0.9.0-incubating rc3. > > >> > > > >> > * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc3 > > >> > * > > >> > > > >> > > https://github.com/apache/polaris/tree/apache-polaris-0.9.0-incubating-rc3 > > >> > * > > >> > > > >> > > https://github.com/apache/polaris/tree/aaf5d42b1959fd8d2bf617fdbe6dcf7e5b9a1eca > > >> > > > >> > The release source tarball, signature, and checksums are here: > > >> > * > > >> > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0-incubating/ > > >> > > > >> > You can find the KEYS file here: > > >> > * https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS > > >> > > > >> > NB: this release doesn't provide any binary distribution, it provides > > >> > source distribution only. > > >> > > > >> > Please download, verify, and test. > > >> > > > >> > Please vote in the next 72 hours. > > >> > [ ] +1 Release this as Apache polaris 0.9.0-incubating > > >> > [ ] +0 > > >> > [ ] -1 Do not release this because... > > >> > > > >> > Only PPMC members and mentors have binding votes, but other community > > >> > members are encouraged to cast non-binding votes. This vote will pass > > >> > if there are > > >> > 3 binding +1 votes and more binding +1 votes than -1 votes. > > >> > > > >> > NB: if this vote passes, a new vote will be started on the Incubator > > >> > general mailing list. > > >> > > > >> > Thanks > > >> > Regards > > >> > JB > > >> > > > >> > > > > >
