Thanks, JB, for coordinating this effort. After briefly reviewing the code base, I believe it makes sense to put this as a new module within the existing repo. The module's code size is manageable, and consolidating it into one repo helps us avoid the extra overhead associated with maintaining multiple repositories.
Additionally, if the module requires dependencies on other Polaris components beyond REST API calls—for example, polaris-core—that provides another compelling reason to keep everything in the same repository. Yufei On Tue, Feb 11, 2025 at 5:29 PM Dennis Huo <huoi...@gmail.com> wrote: > This is great to hear, thanks for helping arrange this! > > +1 to having this tool in Polaris and +1 inviting one of the original main > contributors of the code. > > I don't feel too strongly about separate repo vs additional module, since I > could see pros/cons of either approach. Would be a bit cleaner to manage in > a separate repo, but having in the same repo might improve discoverability, > optionally incorporating certain end-to-end test flows that might make use > of the tool, and maybe open-api and library dependencies would be easier to > iterate on before if the interfaces are still evolving. > > So I would slightly lean towards module in the same Polaris repo, but I can > be convinced otherwise. > > On Tue, Feb 11, 2025 at 10:46 AM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > Hi folks, > > > > As discussed with some of you, we would like to propose donating the > > Nessie Iceberg Catalog migrator tool > > (https://github.com/projectnessie/iceberg-catalog-migrator) to Apache > > Polaris. > > > > A SGA has been already signed in case we accept the donation. > > > > In terms of donation, I propose the following: > > - the iceberg-catalog-migration can land in a separate Polaris repo > > (as it is today for Nessie): > > https://github.com/apache/polaris-catalog-migration or land as a > > module in polaris repo directly > > - we need to prepare the donation by changing the package names, etc > > - I would suggest to consider inviting one of the main contributor of > > Catalog Migrator (ajantha-bhat) as Polaris committer > > > > WDYT ? Do we accept the iceberg-catalog-migrator tool in Polaris (we > > can do a formal vote if we don't have obvious consensus) ? > > > > Regards > > JB > > >
