+1. Thanks Jonas for the change! Yufei
On Sat, Apr 5, 2025 at 6:45 PM Honah J. <hon...@apache.org> wrote: > Hi folks, > > Thanks for the feedback and discussion so far. Based on our PR discussion > about naming, we’ve simplified “namespace-path” to “namespace” for clarity. > > Please continue to vote. > > Thanks, > Honah (Jonas) > > On Fri, Apr 4, 2025 at 8:22 PM Dmitri Bourlatchkov <di...@apache.org> > wrote: > > > Thanks for the update Honah! > > > > Upgrading my vote to +1 > > > > Cheers, > > Dmitri. > > > > On Fri, Apr 4, 2025 at 7:54 PM Honah J. <hon...@apache.org> wrote: > > > > > Thank you for your comment. Based on our discussion, I renamed the new > > > "namespaces" field to "namespace-path". This change better reflects > that > > > the field identifies a single namespace and differentiates it from the > > > namespace parameter, which is a single string. > > > > > > Please continue to vote. > > > > > > Thanks, > > > Honah(Jonas) > > > > > > On Fri, Apr 4, 2025 at 4:42 PM Dmitri Bourlatchkov <di...@apache.org> > > > wrote: > > > > > > > +0 the PR looks ok to me, but I made a non-critical comment in GH. > > > > > > > > Thanks, > > > > Dmitri. > > > > > > > > On Fri, Apr 4, 2025 at 5:23 PM Honah J. <hon...@apache.org> wrote: > > > > > > > > > Hi folks, > > > > > > > > > > I'd like to raise a vote for adding `inhertied` and `namespaces` > > fields > > > > to > > > > > GetApplicablePolicies' response. These fields give users more > > > information > > > > > about whether the effective policy is inherited from its parent and > > the > > > > > namespaces where the effective policy is located. You can find more > > > > details > > > > > in the discussion thread: > > > > > > > > > > https://lists.apache.org/thread/z2lh1cqjcznc1qvtwy46bq18p6psz5bn > > > > > > > > > > This vote will be open for at least 72 hours. > > > > > > > > > > [ ] +1 Merge https://github.com/apache/polaris/pull/1277 > > > > > [ ] +0 > > > > > [ ] -1 Do not merge because... > > > > > > > > > > > > > > >
