Hi Pierre Good catch (I'm sure I had the driver in the admin distribution too at some point as I updated the LICENSE).
I'm cherry picking to the release branch. Thanks ! Regards JB On Thu, Apr 24, 2025 at 9:07 PM Pierre Laporte <pie...@pingtimeout.fr> wrote: > > Also -1 (non-binding) > > The postgresql driver is correctly bundled in the server distribution. But > it is missing from the the admin tool distribution. See below > > ``` > $ unzip -l ~/Downloads/polaris-quarkus-admin-0.10.0-beta-incubating.zip | > grep postgres > $ > $ unzip -l ~/Downloads/polaris-quarkus-server-0.10.0-beta-incubating.zip | > grep postgres > 1087908 04-23-2025 11:02 > polaris-quarkus-server-0.10.0-beta-incubating/lib/main/org.postgresql.postgresql-42.7.5.jar > $ > ``` > > Users would be able to run Polaris but not to bootstrap the server with the > current package. Note that this was just fixed as per > https://github.com/apache/polaris/pull/1447. No additional action is > needed. > > -- > > Pierre > > > On Thu, Apr 24, 2025 at 8:55 PM Michael Collado <collado.m...@gmail.com> > wrote: > > > I will dig into the AWS failure. The other two failures should simply > > require copy/paste from the test output :) > > > > Mike > > > > > On Apr 24, 2025, at 11:46 AM, Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > > > > Hi Michael > > > > > > Good catch. I guess we don’t execute these tests in CI by by gradle > > default > > > task (build) right ? We should include it. > > > > > > I agree the tests have to pass. > > > > > > I will cancel this vote and we have to fix the tests on main and on the > > > release branch. > > > > > > If no volunteer I will fix these tests. > > > > > > Thanks ! > > > Regards > > > JB > > > > > > Le jeu. 24 avr. 2025 à 20:36, Michael Collado <collado.m...@gmail.com> a > > > écrit : > > > > > >> -1 (non-binding) > > >> > > >> There are test failures in the regression tests. A couple of them seem > > >> small - the spark_sql_basic.sh.ref file reports an incorrect response > > from > > >> the catalog creation. > > >> > > >> However, the AWS test_spark_sql_s3_with_privileges.py test also fails > > with > > >> this assertion: > > >> > > >> 2025-04-24 11:00:35 > assert 'Contents' in data_objects > > >> 2025-04-24 11:00:35 E AssertionError: assert 'Contents' in > > >> {'CommonPrefixes': [{'Prefix': > > >> > > 'polaris_test/snowflake_catalog/db1/schema/iceberg_test_table_4a2efdb543/obj_layout/0001/1101/'}], > > >> 'Delimiter': '/', 'EncodingType': 'url', 'IsTruncated': False, ...} > > >> > > >> I think the tests ought to be passing. > > >> > > >> Mike > > >> > > >>> On Apr 23, 2025, at 8:57 AM, Jean-Baptiste Onofré <j...@nanthrax.net> > > >> wrote: > > >>> > > >>> Hi > > >>> > > >>> I removed the index.yaml, I re-add it (for testing purpose). > > >>> > > >>> Regards > > >>> JB > > >>> > > >>> On Wed, Apr 23, 2025 at 5:16 PM Dmitri Bourlatchkov <di...@apache.org> > > >> wrote: > > >>>> > > >>>> It looks like index.yaml comes and goes randomly :| > > >>>> > > >>>> On Wed, Apr 23, 2025 at 11:12 AM Dmitri Bourlatchkov < > > >>>> dmitri.bourlatch...@dremio.com> wrote: > > >>>> > > >>>>> Now, in my env, this worked: > > >>>>> > > >>>>> helm repo add polaris > > >>>>> https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/ > > >>>>> > > >>>>> but: > > >>>>> > > >>>>> $ helm repo update > > >>>>> Hang tight while we grab the latest from your chart repositories... > > >>>>> ...Unable to get an update from the "polaris" chart repository ( > > >>>>> https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/ > > ): > > >>>>> failed to fetch > > >>>>> > > >> > > https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/index.yaml > > >>>>> : 404 Not Found > > >>>>> > > >>>>> Cheers, > > >>>>> Dmitri. > > >>>>> > > >>>>> On Wed, Apr 23, 2025 at 10:07 AM Alex Dutra > > >> <alex.du...@dremio.com.invalid> > > >>>>> wrote: > > >>>>> > > >>>>>> Hi JB, > > >>>>>> > > >>>>>> The right URL with the release tarball is: > > >>>>>> > > >>>>>> > > >>>>>> > > >> > > https://dist.apache.org/repos/dist/dev/incubator/polaris/0.10.0-beta-incubating/ > > >>>>>> > > >>>>>> With that URL: > > >>>>>> > > >>>>>> +1 (non-binding) > > >>>>>> > > >>>>>> - Verified checksums and signatures > > >>>>>> - Verified the source distribution has no binary file > > >>>>>> - Verified "gradlew rat test" passes on the source distribution > > >>>>>> - Verified it is possible to import Polaris BOM + Polaris Core in a > > >>>>>> Gradle project > > >>>>>> > > >>>>>> However, I just tried to add the Helm chart repo and it failed: > > >>>>>> > > >>>>>> helm repo add polaris > > >>>>>> > > https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/ > > >>>>>> Error: looks like " > > >>>>>> > > https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/"; > > >> is > > >>>>>> not a valid chart repository or cannot be reached: failed to fetch > > >>>>>> > > >>>>>> > > >> > > https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/index.yaml > > >>>>>> : 404 Not Found > > >>>>>> > > >>>>>> I don't think this would prevent the release though, but something > > we > > >> want > > >>>>>> to improve for the future. > > >>>>>> > > >>>>>> Thanks, > > >>>>>> > > >>>>>> Alex > > >>>>>> > > >>>>>> On Wed, Apr 23, 2025 at 2:37 PM Jean-Baptiste Onofré < > > j...@nanthrax.net > > >>> > > >>>>>> wrote: > > >>>>>> > > >>>>>>> Hi everyone, > > >>>>>>> > > >>>>>>> I propose that we release the following RC as the official > > >>>>>>> Apache Polaris 0.10.0-beta-incubating release. > > >>>>>>> > > >>>>>>> * This corresponds to the tag: > > >> apache-polaris-0.10.0-beta-incubating-rc0 > > >>>>>>> * > > >>>>>>> > > >>>>>>> > > >>>>>> > > >> > > https://github.com/apache/polaris/commits/apache-polaris-0.10.0-beta-incubating-rc0 > > >>>>>>> * > > >>>>>>> > > >>>>>>> > > >>>>>> > > >> > > https://github.com/apache/polaris/tree/138fe7ec2883a054c71728b83cdf0c5eb49af21b > > >>>>>>> > > >>>>>>> The release tarball, signature, and checksums are here: > > >>>>>>> * > > >>>>>>> > > >>>>>>> > > >>>>>> > > >> > > https://dist.apache.org/repos/dist/dev/incubator/polaris/apache-polaris-0.10.0-beta-incubating > > >>>>>>> > > >>>>>>> Helm charts are available on: > > >>>>>>> * > > >> https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart > > >>>>>>> NB: the docker images (polaris-server and polaris-admin) will be > > >>>>>> published > > >>>>>>> on DockerHub once release vote passes. > > >>>>>>> > > >>>>>>> You can find the KEYS file here: > > >>>>>>> * > > https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS > > >>>>>>> > > >>>>>>> Convenience binary artifacts are staged on Nexus. The Maven > > >> repositories > > >>>>>>> URLs are: > > >>>>>>> * > > >>>>>>> > > >>>>>> > > >> > > https://repository.apache.org/content/repositories/orgapachepolaris-1004/ > > >>>>>>> * > > >>>>>>> > > >>>>>> > > >> > > https://repository.apache.org/content/repositories/orgapachepolaris-1005/ > > >>>>>>> > > >>>>>>> Please download, verify, and test. > > >>>>>>> > > >>>>>>> Please vote in the next 72 hours. > > >>>>>>> > > >>>>>>> [ ] +1 Release this as Apache polaris 0.10.0-beta-incubating > > >>>>>>> [ ] +0 > > >>>>>>> [ ] -1 Do not release this because... > > >>>>>>> > > >>>>>>> Only PPMC members and mentors have binding votes, but other > > community > > >>>>>>> members are > > >>>>>>> encouraged to cast non-binding votes. This vote will pass if there > > >> are > > >>>>>>> 3 binding +1 votes and more binding +1 votes than -1 votes. > > >>>>>>> > > >>>>>>> NB: if this vote passes, a new vote has to be started on the > > >> Incubator > > >>>>>>> general mailing > > >>>>>>> list. > > >>>>>>> > > >>>>>>> Thanks > > >>>>>>> Regards > > >>>>>>> > > >>>>>>> JB > > >>>>>>> > > >>>>>> > > >>>>> > > >> > > >> > > > >
