Thanks for this feature, Rulin! I did not (yet) review the PR end-to-end, but I see that it adds a new field to PolarisCallContext, namely EntityMutationEngine.
At the same time, JdbcMetaStoreManagerFactory receives EntityMutationEngine via CDI injection. >From my POV the CDI (constructor) approach is preferable, so I wonder if the change in PolarisCallContext could be avoided in favour of passing EntityMutationEngine as a new constructor parameter where applicable. WDYT? Apologies if this is explained in other areas of the PR (I did not read all of it yet). Still, I wonder about you thinking wrt injection of EntityMutationEngine everywhere. Of course, core classes will not use CDI annotations, but we could still leverage their constructors for CDI injection in modules that do have CDI dependencies. Thanks, Dmitri. On Wed, Jun 4, 2025 at 3:07 PM Rulin Xing <ru...@apache.org> wrote: > Hi folks, > > I just opened a PR to add I*nitial SigV4 Auth Support for Catalog > Federation* in Polaris. > > This is part of the work to support credential management for external > service access using a clean and pluggable design. It's based on the > proposal I posted before Apache Polaris Creds Management Proposal > < > https://docs.google.com/document/d/1MAW87DtyHWPPNIEkUCRVUKBGjhh5bPn0GbtV7fifm30/edit?tab=t.0#heading=h.v1rcy31tlwav > > > > Here is the PR: https://github.com/apache/polaris/pull/1805 > > Feedback is welcome — feel free to leave your thoughts in the PR! > > Best, > Rulin >
