> > The diffs of PR 1695 [1] merged to "main" and the corresponding commit > [2] on the 1.0.x branch are different for a GH workflow.
There was a minor difference due to the Python Client CI change in the file python-client.yml that isn't in the 1.0.x branch. It won't impact any other places and it won't impact anything about our src/bin distribution as it is a minor CI change for github. Yufei On Tue, Jun 24, 2025 at 3:05 PM yun zou <yunzou.colost...@gmail.com> wrote: > We will need to take a look at how .pom file is generated today, and > understand > why testImplementation is added as optional "runtime" dependency in the > POM, > whether to fix it only for the spark client? or for all projects? If for > testImplementation, > they are supposed to be only declared as "test", we probably should fix > that for all projects. > > I think we can follow up on this, and potentially do a fix on main. > > Best Regards, > Yun > > On Tue, Jun 24, 2025 at 1:54 PM Dmitri Bourlatchkov <di...@apache.org> > wrote: > > > Thanks, Yun! > > > > Indeed, I do not think test jars are not downloaded by Spark, so this is > > not a problem for 1.0. > > > > Still, why would "testImplementation" dependencies be added as "runtime" > > (not as "test") in POM? Should we still fix it on "main"? WDYT? > > > > Thanks, > > Dmitri. > > > > On Tue, Jun 24, 2025 at 4:49 PM yun zou <yunzou.colost...@gmail.com> > > wrote: > > > > > Hi Dimitri, > > > > > > Regarding polaris-spark-3.5_2.12-1.0.0-incubating.pom, for dependencies > > > like junut-jupyter, mockito-core, those are > > > used by testing and marked as testImplementation in the build file. In > > the > > > .pom file the optional is marked as true for > > > those dependencies, therefore when using it with --package of spark, > > those > > > packages will not be downloaded. So for > > > 1.0 release, I think we should be good. > > > > > > Best Regards, > > > Yun > > > > > > On Tue, Jun 24, 2025 at 12:07 PM Jean-Baptiste Onofré <j...@nanthrax.net > > > > > wrote: > > > > > > > Hi > > > > > > > > I double checked: admin and server share the same micrometer version > > > > (1.14.6). > > > > > > > > You should not use gradle runtimeClasspath dependencies here as it > can > > be > > > > overridden by a transitive. > > > > > > > > You should check in the archive (it’s what I did). > > > > > > > > Regards > > > > JB > > > > > > > > Le mar. 24 juin 2025 à 20:24, Dmitri Bourlatchkov <di...@apache.org> > a > > > > écrit : > > > > > > > > > Hi Yufei, > > > > > > > > > > I think having different micrometer versions in use in the admin > tool > > > and > > > > > server is fine for 1.0. > > > > > > > > > > However, my impression is that those artifacts depend on two > > micrometer > > > > > versions each at the same time, is that so? Could you clarify this > > > (note: > > > > > you mentioned an email attachment, but I do not think it came > > through). > > > > > > > > > > Thanks, > > > > > Dmitri. > > > > > > > > > > On Tue, Jun 24, 2025 at 2:13 PM Yufei Gu <flyrain...@gmail.com> > > wrote: > > > > > > > > > > > > Is there a particular reason for not consolidating the versions > > in > > > > 1.0? > > > > > > > > > > > > I'm fine to have it in 1.0, but it doesn't seem like a > straighford > > > fix. > > > > > We > > > > > > may not consider it as a 1.0 blocker due to the low risk you > > > mentioned. > > > > > > > > > > > > Yufei > > > > > > > > > > > > > > > > > > On Tue, Jun 24, 2025 at 10:53 AM Dmitri Bourlatchkov < > > > di...@apache.org > > > > > > > > > > > wrote: > > > > > > > > > > > > > Hi Yufei, > > > > > > > > > > > > > > Is there a particular reason for not consolidating the versions > > in > > > > 1.0? > > > > > > > > > > > > > > With Micrometer usually doing a good job at cross-version > > > > > compatibility I > > > > > > > would not expect it to be a big or risky change. > > > > > > > > > > > > > > Thanks, > > > > > > > Dmitri. > > > > > > > > > > > > > > On Tue, Jun 24, 2025 at 1:37 PM Yufei Gu <flyrain...@gmail.com > > > > > > wrote: > > > > > > > > > > > > > > > Looking a bit more, both polaris-admin and polaris-server > > depend > > > on > > > > > > > > different versions of io.micrometer. Attached the > dependencies > > > > output > > > > > > for > > > > > > > > both modules. In short, both modules depend on io.micrometer > > > > 1.15.1 > > > > > > and > > > > > > > > 1.14.7. Didn't find 1.14.6 was there. I think this version > > > mismatch > > > > > may > > > > > > > > have an implication in the future. We will need to > consolidate > > > > > > versions, > > > > > > > > which benefits the project in the long-term. For this > > particular > > > > > > > release, I > > > > > > > > will suggest adding licenses for both versions. WDYT? > > > > > > > > > > > > > > > > > > > > > > > > Yufei > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jun 24, 2025 at 9:55 AM Yufei Gu < > flyrain...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > > > > >> -- *BLOCKER* LICENSE is not correct because: > > > > > > > >>> --- caffeine 3.2.1 is documented in the LICENSE file, but > > > > caffeine > > > > > > > >>> 3.2.0 is actually bundled in the server/admin lib folder > > > > > > > >>> --- reactor-core 3.7.6 is documented in the LICENSE file, > but > > > > > > > >>> reactor-core 3.7.7 is actually bundled in the server/admin > > lib > > > > > folder > > > > > > > >>> --- micrometer-* 1.15.1 are documented in the LICENSE file, > > but > > > > > > > >>> micrometer-* 1.14.6 is actually bundled in the server/admin > > lib > > > > > > folder > > > > > > > >>> --- hamcrest 2.2 is present in the server lib folder but > not > > > > > > > >>> documented in the LICENSE file > > > > > > > >>> --- awaitility 4.3.0 is present in the server lib folder > but > > > not > > > > > > > >>> documented in the LICENSE file > > > > > > > >> > > > > > > > >> JB, thanks for identifying these license issues, these were > > > > > introduced > > > > > > > by > > > > > > > >> changes after our license PR. Let's fix them. > > > > > > > >> > > > > > > > >> - helm chart is not in the right folder (see > > > > > > > >>> > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/polaris/blob/main/site/content/release-guide.md?plain=1#L166 > > > > > > > >>> ) > > > > > > > >> > > > > > > > >> This will be fixed in the next RC. > > > > > > > >> > > > > > > > >> - in 0.10.x, I staged a Docker image for review (see > > > > > > > >> > > > > > > > >> My plan is to publish docker images after 1.0 release, which > > is > > > > > > > suggested > > > > > > > >> by the guide "NB: the docker images (polaris-server and > > > > > polaris-admin) > > > > > > > will > > > > > > > >> be > > > > > > > >> published on DockerHub once release vote passes." > > > > > > > >> > > > > > > > >> With that, I will cancel this RC due to the license issue. > > > > > > > >> > > > > > > > >> Yufei > > > > > > > >> > > > > > > > >> > > > > > > > >> On Tue, Jun 24, 2025 at 9:42 AM Jean-Baptiste Onofré < > > > > > j...@nanthrax.net > > > > > > > > > > > > > > >> wrote: > > > > > > > >> > > > > > > > >>> -1 (binding) > > > > > > > >>> > > > > > > > >>> Here's what I checked: > > > > > > > >>> - KEYS has been updated and gpg server too > > > > > > > >>> - Source distribution > > > > > > > >>> -- signature and checksum are good > > > > > > > >>> -- DISCLAIMER is present and good > > > > > > > >>> -- LICENSE and NOTICE look good > > > > > > > >>> -- no binary file found in the source distribution > > > > > > > >>> -- Header look good in file (ASF/Dremio headers) > > > > > > > >>> - Binary distribution > > > > > > > >>> -- NB: there's no problem to use polaris-bin as name as > soon > > as > > > > the > > > > > > > >>> version contain incubating > > > > > > > >>> -- signature and checksum are good > > > > > > > >>> -- DISCLAIMER is present and good > > > > > > > >>> -- *BLOCKER* LICENSE is not correct because: > > > > > > > >>> --- caffeine 3.2.1 is documented in the LICENSE file, but > > > > caffeine > > > > > > > >>> 3.2.0 is actually bundled in the server/admin lib folder > > > > > > > >>> --- reactor-core 3.7.6 is documented in the LICENSE file, > but > > > > > > > >>> reactor-core 3.7.7 is actually bundled in the server/admin > > lib > > > > > folder > > > > > > > >>> --- micrometer-* 1.15.1 are documented in the LICENSE file, > > but > > > > > > > >>> micrometer-* 1.14.6 is actually bundled in the server/admin > > lib > > > > > > folder > > > > > > > >>> --- hamcrest 2.2 is present in the server lib folder but > not > > > > > > > >>> documented in the LICENSE file > > > > > > > >>> --- awaitility 4.3.0 is present in the server lib folder > but > > > not > > > > > > > >>> documented in the LICENSE file > > > > > > > >>> > > > > > > > >>> Nit (not blocker): > > > > > > > >>> - helm chart is not in the right folder (see > > > > > > > >>> > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/polaris/blob/main/site/content/release-guide.md?plain=1#L166 > > > > > > > >>> ) > > > > > > > >>> - in 0.10.x, I staged a Docker image for review (see > > > > > > > >>> > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/polaris/pull/1915/files#diff-4550e2201644991527d084c7d544c0c8b9ce97d41e129cc2a627a85949ae030bR186 > > > > > > > >>> ). > > > > > > > >>> It's not a blocker for the release, we can always push the > > > Docker > > > > > > > >>> image after the release vote. I can also stage a Docker > image > > > on > > > > > the > > > > > > > >>> tag. > > > > > > > >>> - polaris spark client bundle artifact contains two LICENSE > > and > > > > > > NOTICE > > > > > > > >>> files in the root folder. Luckily the last extracted are > the > > > good > > > > > > ones > > > > > > > >>> but it's not great. We should exclude LICENSE/NOTICE coming > > > from > > > > > > > >>> shaded dependencies to keep only our LICENSE/NOTICE file. > > > > > > > >>> - the email body/subject txt files can be removed from the > > dist > > > > > > > >>> repository > > > > > > > >>> > > > > > > > >>> I will work with Yufei to fix the LICENSE/NOTICE content in > > the > > > > > > binary > > > > > > > >>> distribution. > > > > > > > >>> > > > > > > > >>> Regards > > > > > > > >>> JB > > > > > > > >>> > > > > > > > >>> > > > > > > > >>> > > > > > > > >>> > > > > > > > >>> > > > > > > > >>> On Tue, Jun 24, 2025 at 3:23 AM Yufei Gu < > > flyrain...@gmail.com > > > > > > > > > > wrote: > > > > > > > >>> > > > > > > > > >>> > Hi everyone, > > > > > > > >>> > > > > > > > > >>> > I propose that we release the following RC as the > official > > > > > > > >>> > Apache Polaris 1.0.0-incubating release. > > > > > > > >>> > > > > > > > > >>> > This corresponds to the tag: > > > > apache-polaris-1.0.0-incubating-rc0 > > > > > > > >>> > * > > > > > > > >>> > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/polaris/commits/apache-polaris-1.0.0-incubating-rc0 > > > > > > > >>> > * > > > > > > > >>> > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/polaris/tree/3e3cd23dfdc261686f3935c8ea2c472b0bd3e8b8 > > > > > > > >>> > > > > > > > > >>> > The release tarball, signature, and checksums are here, > > which > > > > > > > includes > > > > > > > >>> both > > > > > > > >>> > source code distribution and a single binary > distribution: > > > > > > > >>> > * > > > > > > > >>> > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/polaris/apache-polaris-1.0.0-incubating > > > > > > > >>> > > > > > > > > >>> > You can find the KEYS file here: > > > > > > > >>> > * https://downloads.apache.org/incubator/polaris/KEYS > > > > > > > >>> > > > > > > > > >>> > Convenience binary artifacts are staged on Nexus. The > Maven > > > > > > > repository > > > > > > > >>> URL > > > > > > > >>> > is: > > > > > > > >>> > * > > > > > > > >>> > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachepolaris-1020/org/apache/polaris/ > > > > > > > >>> > > > > > > > > >>> > Please download, verify, and test. > > > > > > > >>> > > > > > > > > >>> > Please vote in the next 72 hours. > > > > > > > >>> > > > > > > > > >>> > [ ] +1 Release this as Apache polaris 1.0.0-incubating > > > > > > > >>> > [ ] +0 > > > > > > > >>> > [ ] -1 Do not release this because... > > > > > > > >>> > > > > > > > > >>> > Only PPMC members and mentors have binding votes, but > other > > > > > > community > > > > > > > >>> > members are > > > > > > > >>> > encouraged to cast non-binding votes. This vote will pass > > if > > > > > there > > > > > > > are > > > > > > > >>> 3 > > > > > > > >>> > binding +1 votes and more binding +1 votes than -1 votes. > > > > > > > >>> > > > > > > > > >>> > NB: if this vote passes, a new vote has to be started on > > the > > > > > > > Incubator > > > > > > > >>> > general mailing > > > > > > > >>> > list. > > > > > > > >>> > > > > > > > > >>> > Thanks > > > > > > > >>> > Yufei > > > > > > > >>> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > >
