Thanks Dennis for flagging this. Good news is that it's a clean cherry-pick. Cancelling RC5, will cut RC6 with the fix( https://github.com/apache/polaris/commit/22eaff4fed431715ec8efc8c749a1707c99c48e7 ).
Yufei On Tue, Jul 1, 2025 at 11:49 PM Dennis Huo <huoi...@gmail.com> wrote: > -1 (binding) > > Given the nature of the broken "list" operations in federation towards > usability and the fairly straightforward already-merged fix to pick, my > vote is to cut a new RC6 for the fix. > > On Tue, Jul 1, 2025 at 11:22 PM Dennis Huo <huoi...@gmail.com> wrote: > > > Sorry for surfacing this late, but I hadn't noticed > > https://github.com/apache/polaris/issues/1848 before (already fixed at > > head by Rulin's https://github.com/apache/polaris/pull/1849) > > > > I can't remember whether we formally considered Federation bugs to be 1.0 > > blockers, but it's one of the big features in 1.0 and most active client > > libraries send null pageSize by default, so in the current RC5 > > listNamespaces/listTables/listViews will be broken for most workflows. > > > > My preference is to pick > > > https://github.com/apache/polaris/commit/22eaff4fed431715ec8efc8c749a1707c99c48e7 > > if possible. > > > > Otherwise, tested building from RC5 source tarball, configuring features > > successfully. Tested that federation works with the aforementioned fix. > > > > On Tue, Jul 1, 2025 at 10:06 PM Prashant Singh > > <prashant.si...@snowflake.com.invalid> wrote: > > > >> +1 (non binding) > >> > >> I verified the following: > >> - Source tarball (shasum and GPG signature) > >> - Build and test > >> - Verified server binary distribution > >> - basic sanity testing with JDBC persistence layer > >> > >> Thank you Yufei ! > >> > >> Bests, > >> Prashant > >> > >> On Tue, Jul 1, 2025 at 9:47 PM Jean-Baptiste Onofré <j...@nanthrax.net> > >> wrote: > >> > >> > +1 (binding) > >> > > >> > I checked: > >> > - Source distribution > >> > -- incubating is in the version > >> > -- signature and checksum are good > >> > -- DISCLAIMER is present > >> > -- LICENSE and NOTICE are good (personally, I think NOTICE should not > >> > mention Nessie as it's just the copyright and already in the LICENSE, > >> > but one IPMC asked that during 0.9.0 release vote) > >> > -- No binary file found in the source distribution > >> > -- Headers look correct (NB: the files without header are coming from > >> > other projects as mentioned in the LICENSE file and the original file > >> > doesn't contain a header, like Docsy or Mustache templates). Nit: the > >> > svg file (from the project) could contain ASF header. > >> > -- Build works from source distribution > >> > - Binary distribution > >> > -- incubating is in the version > >> > -- signature and checksum are good > >> > -- DISCLAIMER is present > >> > -- LICENSE and NOTICE look good > >> > -- Can start Polaris server from the binary distribution > >> > - Helm Chart Package > >> > -- incubating is in the version > >> > -- DISCLAIMER is present > >> > -- LICENSE and NOTICE are good > >> > -- Signature and checksum are good in prov file > >> > -- Header are ok as it's a helm chart "package" (not source > >> distribution) > >> > - Bundle jar files (Spark plugin) > >> > -- incubating is in the name > >> > -- signature and checksum are good on the staging Maven repository > >> > -- LICENSE and NOTICE look good (documented all bundled artifacts in > >> > the Spark plugin) > >> > > >> > Regards > >> > JB > >> > > >> > On Mon, Jun 30, 2025 at 11:11 PM Yufei Gu <flyrain...@gmail.com> > wrote: > >> > > > >> > > Hi everyone, > >> > > > >> > > I propose that we release the following RC as the official Apache > >> Polaris > >> > > 1.0.0-incubating release. > >> > > > >> > > This corresponds to the tag: apache-polaris-1.0.0-incubating-rc5 > >> > > * > >> > > > >> > > >> > https://github.com/apache/polaris/commits/apache-polaris-1.0.0-incubating-rc5 > >> > > * > >> > > > >> > > >> > https://github.com/apache/polaris/tree/9da4e414ef907919c31a1521eccbf1f1198c734d > >> > > > >> > > The release tarball, signature, and checksums are here, including > both > >> > > source code and binary distributions: > >> > > * > >> > > > >> > > >> > https://dist.apache.org/repos/dist/dev/incubator/polaris/apache-polaris-1.0.0-incubating/ > >> > > > >> > > > >> > > A binary package for Helm chart: > >> > > > >> > > * > >> > > > >> > > >> > https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/1.0.0-incubating/ > >> > > NB: File > >> > > > >> > > >> > https://dist.apache.org/repos/dist/dev/incubator/polaris/helm-chart/1.0.0-incubating/polaris-1.0.0-incubating.tgz.prov > >> > > contains both signature and checksum for the package. Please verify > it > >> > with > >> > > the command `helm verify`. > >> > > The docker images (polaris-server and polaris-admin) will be > >> published on > >> > > DockerHub once release vote passes. > >> > > > >> > > You can find the KEYS file here: > >> > > * https://downloads.apache.org/incubator/polaris/KEYS > >> > > > >> > > Convenience binary artifacts are staged on Nexus. The Maven > repository > >> > URL > >> > > is: > >> > > * > >> > > >> > https://repository.apache.org/content/repositories/orgapachepolaris-1026/ > >> > > > >> > > Please download, verify, and test. > >> > > > >> > > Please vote in the next 72 hours. > >> > > > >> > > [ ] +1 Release this as Apache polaris 1.0.0-incubating > >> > > [ ] +0 > >> > > [ ] -1 Do not release this because... > >> > > > >> > > Only PPMC members and mentors have binding votes, but other > community > >> > > members are > >> > > encouraged to cast non-binding votes. This vote will pass if there > >> are 3 > >> > > binding +1 votes and more binding +1 votes than -1 votes. > >> > > > >> > > NB: if this vote passes, a new vote has to be started on the > Incubator > >> > > general mailing list. > >> > > > >> > > > >> > > > >> > > Yufei > >> > > >> > > >
