Hi Yufei, application.property changes in PR [2650] look quite reasonable to me.
They are the main purpose of this PR, which is to enable connecting to Aurora DB for users that want to do that. I do not see how it can have any adverse effects on existing users that do not want to use Aurora DB. All other PostgreSQL connections should continue working as before. Documentation changes are not required for existing PostgreSQL users to continue using other systems (not Aurora), so this PR is a non-breaking change as far as I can tell. Do you still think any specific changes are needed in [2650]? [2650] https://github.com/apache/polaris/pull/2650 Thank you, Dmitri. On Fri, Sep 26, 2025 at 12:49 PM Yufei Gu <[email protected]> wrote: > Hi Dimitri, thanks for keeping me in the loop. Thanks a lot Fabio for > keeping working on it. Just copied my reply in the PR. > > I'm good with a follow-up doc PR. In that case, I suggest we remove the > > configuration changes from both application.properties files. We add a > new > > jdbc connection option in this PR. We got two options now. Users might > > confused by which option to choose, how they set it, especially since > > neither file includes a complete setup for both. > > > Yufei > > > On Fri, Sep 26, 2025 at 8:54 AM Dmitri Bourlatchkov <[email protected]> > wrote: > > > Hi Yufei, > > > > Would you be ok with making doc changes in a follow-up PR? > > > > Thanks, > > Dmitri. > > > > On Thu, Sep 25, 2025 at 8:06 PM Dmitri Bourlatchkov <[email protected]> > > wrote: > > > > > Hi Yufei, > > > > > > We discussed docs in GH comments. I believe the plan is to make doc > > > changes in a separate PR. > > > > > > Cheers, > > > Dmitri. > > > > > > On Thu, Sep 25, 2025 at 7:28 PM Yufei Gu <[email protected]> wrote: > > > > > >> Hi Dmitri, Thanks for the heads up! Appreciate the review. > > >> Hi Fabio, I appreciate it for working on this. The PR LGTM overall. I > > >> think > > >> it'd add more values to present as a formal doc instead of comments in > > >> application.properties. Let me know if any help is required. > > >> > > >> Yufei > > >> > > >> > > >> On Thu, Sep 25, 2025 at 11:26 AM Dmitri Bourlatchkov < > [email protected]> > > >> wrote: > > >> > > >> > Heads up: the PR LGTM. > > >> > > > >> > If no concerns are raised, I propose to merge on Sept 26. > > >> > > > >> > Cheers, > > >> > Dmitri. > > >> > > > >> > On 2025/09/23 22:50:57 Dmitri Bourlatchkov wrote: > > >> > > To sync up with GH, here's the Aurora PR: > > >> > https://github.com/apache/polaris/pull/2650 > > >> > > > > >> > > Kudos to Fabio for implementing it. > > >> > > > > >> > > Cheers, > > >> > > Dmitri. > > >> > > > > >> > > On 2025/09/08 12:16:22 "Rizzo Cascio, Fabio" wrote: > > >> > > > Hi guys, > > >> > > > > > >> > > > I was trying to create use the helm chart and new image to > deploy > > >> > Polaris in our cluster (EKS). > > >> > > > We can’t use username and password, from what I can see in > Polaris > > >> we > > >> > only support jdbc connections with username and password. > > >> > > > > > >> > > > What is the plan to support passwordless DBs? > > >> > > > > > >> > > > Thanks > > >> > > > > > >> > > > Fabio > > >> > > > > > >> > > > This message is confidential and subject to terms at: > > >> > https://www.jpmorgan.com/emaildisclaimer including on confidential, > > >> > privileged or legal entity information, malicious content and > > >> monitoring of > > >> > electronic messages. If you are not the intended recipient, please > > >> delete > > >> > this message and notify the sender immediately. Any unauthorized use > > is > > >> > strictly prohibited. > > >> > > > > > >> > > > > >> > > > >> > > > > > >
