Hi all,

This is a dedicated email thread for the proposal at #2616 
<https://github.com/apache/polaris/pull/2616>, which I’ve proposed for a 
potential 2.0.0 release.

The rationale for making this change is that returning a 201 (Created) response 
code is incorrect and technically, in violation of RFC 9110 
<https://datatracker.ietf.org/doc/rfc9110/> Section 15.3.2, which reads:

>  The 201 (Created) status code indicates that the request has been
>    fulfilled and has resulted in one or more new resources being
>    created.

Given there are no resources being created, according to spec, we should 
definitely not be returning back a 201 response code. In line with similar APIs 
currently in Polaris, I believe the correct response code would be 204 (No 
Content), as we only return successfully on this API if the processing of this 
revocation is complete - there is no additional information present in 
processing this call that was not already present in the request.

As for consequences of making this change, I don’t see them being extremely 
large if done properly via a major version bump - which implies that there can 
be breaking changes as part of the release already. Changing clients from 
expecting HTTP code 201 to 204 should not be a cumbersome change comparatively 
to what other potentially breaking changes may be part of the release already.

Best,
Adnan Hemani

Reply via email to