Hi all,

I noticed an issue with the enum PolarisStorageActions and table
location validation logic.

Currently, the logic is implemented in InMemoryStorageIntegration [1].
The validating method accepts a Set<PolarisStorageActions> parameter.
However, this parameter is currently ignored; the validation logic is
the same whether we pass READ or WRITE (or ALL). It only checks
whether the location is a child of one of the allowed locations. The
only call site, by the way, always passes ALL.

I'm wondering if we should remove this parameter entirely, or if this
parameter was intended for a future usage?

Thanks,
Alex


[1] 
https://github.com/apache/polaris/blob/17a822eb17c5db7b0ae1a980241306ae1560e042/polaris-core/src/main/java/org/apache/polaris/core/storage/InMemoryStorageIntegration.java#L57

Reply via email to