Hi Phillip, Indeed there seems to be no `clientId` parameter, even for CREDENTIAL_MODE_VENDED_CREDENTIALS. I would suggest removing this parameter for now.
Let's continue the discussion around implementation details in the PR. Thanks, Alex On Fri, Feb 13, 2026 at 10:08 AM Phillip Henry <[email protected]> wrote: > > Thanks, Alex. > > This is very reassuring since this is my first (hopefully of many!) Polaris > PR. > > I've had a think though and realise that my > GcpAuthenticationParameters/clientId is not used in the > CREDENTIAL_MODE_END_USER use case (that is, the use case for which I raised > this PR as my company needs it). > > It *may* be used when we implement the CREDENTIAL_MODE_VENDED_CREDENTIALS > use case - I don't know yet. (I'll hopefully write a PR for this later.) > > However, it's not needed for *this* PR so should I remove it? > > Regards, > > Phillip > > On Thu, Feb 12, 2026 at 1:47 PM Alexandre Dutra <[email protected]> wrote: > > > Hi Phillip, > > > > Thanks for bringing this topic to the community's attention! > > > > I reviewed the PR and am +1 with the overall direction taken there. > > > > Thanks, > > Alex > > > > On Wed, Feb 11, 2026 at 11:29 PM Yufei Gu <[email protected]> wrote: > > > > > > Thanks Phillip for raising it. It does seem a right direction given the > > > discussion in the upstream PR, > > https://github.com/apache/iceberg/pull/13212. > > > I will need to take a close look. > > > > > > Yufei > > > > > > > > > On Wed, Feb 11, 2026 at 7:20 AM Dmitri Bourlatchkov <[email protected]> > > > wrote: > > > > > > > Hi Phillip, > > > > > > > > Thanks for starting this discussion! > > > > > > > > From my POV the REST API change is backward-compatible and a nice > > > > enhancement to Polaris. > > > > > > > > I posted some technical review comments in GH. > > > > > > > > It would be nice to get additional reviews from people more familiar > > with > > > > the External Catalogs feature. > > > > > > > > Cheers, > > > > Dmitri. > > > > > > > > On Wed, Feb 11, 2026 at 6:12 AM Phillip Henry <[email protected] > > > > > > > wrote: > > > > > > > > > I've added a REST API class (GcpAuthenticationParameters) in an > > attempt > > > > to > > > > > address #3451 <https://github.com/apache/polaris/issues/3451> - > > that is, > > > > > allowing users to create external catalogs that use the > > GoogleAuthManager > > > > > in the Iceberg codebase. > > > > > > > > > > I've put together this pull request > > > > > <https://github.com/apache/polaris/pull/3729> that hopefully > > implements > > > > > this. Other than adding an extra enum element to > > > > AuthenticationParameters, > > > > > there are no changes to existing classes. > > > > > > > > > > Dmitri Bourlatchkov has told me this necessitates a discussion in the > > > > > mailing lists and asked me to kick one off. So can I please ask for > > > > > opinions? > > > > > > > > > > Thanks, > > > > > > > > > > Phillip > > > > > > > > > > >
