Regarding the points Rulin Xing raises on ticket 3729
<https://github.com/apache/polaris/pull/3729#discussion_r2866294655>, I
wanted to get some feedback from the community on the following.


   1. I'd argue that project id property should not live on
   IcebergRestConnectionConfigInfo as it's GCP specific AFAIK
   2. If it were to live in IcebergRestConnectionConfigInfo as a map of
   properties in (I think that's what you're suggesting RX - correct me if I'm
   wrong) then its presence could not be enforced for GCP calls.
   3. GcpAuthenticationParametersDpo "doesn't contain any
   authentication-related info" but it does contain only what is necessary to
   trigger AuthManagers to use GCP and also to provide the means to do that
   via its asIcebergCatalogProperties and asAuthenticationParametersModel
   methods. I'd argue that this way of doing it leverages the machinery that's
   already in place and minimally impacts the rest of the codebase.


So, I'd propose removing the warehouse field as RX has helpfully pointed
out but I think GcpAuthenticationParametersDpo should stay even if its DTO
counterpart is revised.

Thoughts?

Reply via email to