Merged. On Tue, Apr 28, 2026 at 9:15 AM Dmitri Bourlatchkov <[email protected]> wrote:
> Hi All, > > PR [3729] adding support for GoogleAuthManager got adjusted to follow the > pattern of using generic Federated Catalog properties that emerged in other > recent PRs. > > Its REST API change is rather minimal now (it adds a new type value). > > All in all, the PR looks good to merge from my POV. Many reviewers have > engaged with this PR over time, but few remain active on it now. Please > consider making one more review pass and indicate your approval or flag any > remaining concerns. > > [3729] https://github.com/apache/polaris/pull/3729 > > Thanks, > Dmitri. > > On Mon, Apr 6, 2026 at 9:54 AM Dmitri Bourlatchkov <[email protected]> > wrote: > >> Hi All, >> >> It looks like the discussion on this PR is no so active anymore. I >> personally think the changes are good to merge. >> >> Does anyone have any remaining concerns? >> >> Thanks, >> Dmitri. >> >> On Mon, Mar 30, 2026 at 5:14 PM Dmitri Bourlatchkov <[email protected]> >> wrote: >> >>> Heads up: >>> https://github.com/apache/polaris/pull/3729#discussion_r3010985756 >>> >>> Rulin proposed expanding the config for Iceberg Catalog Federation to >>> cover this use case and possible other advanced use cases. >>> >>> Since this affects the REST API types, I think it makes sense to hold >>> the merge (to avoid making breaking changes soon after) and see how that >>> discussion resolves. >>> >>> Cheers, >>> Dmitri. >>> >>> On Mon, Mar 30, 2026 at 2:47 PM Jean-Baptiste Onofré <[email protected]> >>> wrote: >>> >>>> It sounds good to me. >>>> >>>> Thanks, >>>> Regards >>>> JB >>>> >>>> On Mon, Mar 30, 2026 at 4:52 PM Dmitri Bourlatchkov <[email protected]> >>>> wrote: >>>> >>>> > Hi All, >>>> > >>>> > Heads up: I'm going to merge PR 3729 tomorrow (it's already approved) >>>> > unless new comments appear. >>>> > >>>> > Cheers, >>>> > Dmitri. >>>> > >>>> > On Thu, Mar 12, 2026 at 2:17 PM Dmitri Bourlatchkov <[email protected] >>>> > >>>> > wrote: >>>> > >>>> > > Hi All, >>>> > > >>>> > > PR [3729] received a few approvals in GH. >>>> > > >>>> > > Any objections to merging it? >>>> > > >>>> > > [3729] https://github.com/apache/polaris/pull/3729 >>>> > > >>>> > > Thanks, >>>> > > Dmitri. >>>> > > >>>> > > On Wed, Feb 11, 2026 at 6:12 AM Phillip Henry < >>>> [email protected]> >>>> > > wrote: >>>> > > >>>> > >> I've added a REST API class (GcpAuthenticationParameters) in an >>>> attempt >>>> > to >>>> > >> address #3451 <https://github.com/apache/polaris/issues/3451> - >>>> that >>>> > is, >>>> > >> allowing users to create external catalogs that use the >>>> > GoogleAuthManager >>>> > >> in the Iceberg codebase. >>>> > >> >>>> > >> I've put together this pull request >>>> > >> <https://github.com/apache/polaris/pull/3729> that hopefully >>>> implements >>>> > >> this. Other than adding an extra enum element to >>>> > AuthenticationParameters, >>>> > >> there are no changes to existing classes. >>>> > >> >>>> > >> Dmitri Bourlatchkov has told me this necessitates a discussion in >>>> the >>>> > >> mailing lists and asked me to kick one off. So can I please ask for >>>> > >> opinions? >>>> > >> >>>> > >> Thanks, >>>> > >> >>>> > >> Phillip >>>> > >> >>>> > > >>>> > >>>> >>>
