Hi,

I'm working on Implement semantic model document validation (#5205)
<https://github.com/apache/polaris/issues/5205> and have opened a draft PR:

#5895 <https://github.com/apache/polaris/pull/5895>

*Summary*: Create/update validate the semantic_model body against a bundled
Apache Ossie JSON Schema (version selected by the document’s version,
currently 0.2.0.dev0 only). Oversized bodies are rejected via a new realm
flag SEMANTIC_MODEL_MAX_DOCUMENT_BYTES (default 1 MiB), checked in the
catalog before parsing.

Two items I’d like dev-list input on before marking the PR ready for review:

   1.

   New dependency: com.networknt:json-schema-validator 1.5.9 (Apache 2.0),
   used only in extensions/semantic-models for draft 2020-12 schema
   validation on Jackson JsonNodes. Transitive com.ethlo.time:itu is listed
   in the server distribution LICENSE. No network access at validation time;
   the Ossie schema is vendored on the classpath.
   2.

   Interface change:
   SemanticDocumentValidator#validate(SemanticModelDocument) becomes
validate(SemanticModelDocument,
   JsonNode) so the body is not parsed twice. There are no other
   implementations today; semantic models remain behind
   ENABLE_SEMANTIC_MODELS (beta, off by default). Version -> schema
   selection is a plain switch on spec version (no CDI), as per discussion on
   the issue.

If there are any concerns about the dependency choice or the signature
change, please reply here.
Thanks,

Arnab

Reply via email to