There are 4 approvals for the PR. I'd proposed to merge it now or
after 1.9.0 is released. There will always be conflicts between the
open PRs and this formatter change. I see no reason to wait for
further.

Yufei

On Mon, Nov 9, 2026 at 9:23 AM Yufei Gu <[email protected]> wrote:
>
> Thanks Yong for raising it up. V2 format the code more compact and
> easier to read. +1 on the PR.
>
> Yufei
>
> On Mon, Nov 9, 2026 at 7:19 AM Dmitri Bourlatchkov via dev
> <[email protected]> wrote:
> >
> > Hi Alex.
> >
> > Good point about cherry-picks!
> >
> > I was initially thinking about outstanding PRs planned for 1.9.0 and did
> > not want to complicate their merging, but now I realise that we do not have
> > any of them left.
> >
> > The Directories API [5927] is probably unaffected by the java format change.
> >
> > So, in the end, I think reformatting before 1.9.0 makes sense.
> >
> > Cheers,
> > Dmitri.
> >
> > [5927] https://github.com/apache/polaris/pull/5927
> >
> > On Mon, Nov 9, 2026 at 10:07 AM Alex Dutra via dev <[email protected]>
> > wrote:
> >
> > > Hi all,
> > >
> > > > do we want to hold this until we branch 1.9.0?
> > >
> > > I think we should do the opposite: otherwise, cherry-picking from main
> > > into the release branch could incur in frequent formatting issues.
> > > WDYT?
> > >
> > > Thanks,
> > > Alex
> > >
> > > On Mon, Nov 9, 2026 at 3:36 PM Dmitri Bourlatchkov via dev
> > > <[email protected]> wrote:
> > > >
> > > > Hi All,
> > > >
> > > > +1 to google format v2 and full reformat in one go.
> > > >
> > > > Practically speaking, do we want to hold this until we branch 1.9.0?
> > > >
> > > > Thanks,
> > > > Dmitri.
> > > >
> > > > On Mon, Nov 9, 2026 at 2:19 AM Jean-Baptiste Onofré <[email protected]>
> > > wrote:
> > > >
> > > > > Hi Yong,
> > > > >
> > > > > +1 to move to google-java-format V2.
> > > > >
> > > > > As I said in PR #5973, 1.37.0 doesn't work with our current Spotless
> > > > > version. v2 also gives more compact code, so I think it's better to do
> > > the
> > > > > full reformat once now.
> > > > >
> > > > > I suggest we give 72 hours for any concern, then we can merge #6010
> > > > > quickly to reduce the risk of conflicts (also it gives time for
> > > > > contributors to update google-java-format in their IDE).
> > > > >
> > > > > For existing PRs, we will have to:
> > > > > - rebase
> > > > > - apply ./gradlew spotlessApply and commit
> > > > >
> > > > > I will review the PR, thanks!
> > > > >
> > > > > Regards
> > > > > JB
> > > > >
> > > > > On Mon, Nov 9, 2026 at 7:50 AM Yong Zheng via dev <
> > > [email protected]>
> > > > > wrote:
> > > > >
> > > > > > Hello team,
> > > > > >
> > > > > > We are planning to update dependency
> > > > > > com.google.googlejavaformat:google-java-format to v2. This is
> > > discussed
> > > > > > between JB and Yufei via https://github.com/apache/polaris/pull/5973
> > > .
> > > > > >
> > > > > > Here is the current PR for this change:
> > > > > > https://github.com/apache/polaris/pull/6010
> > > > > >
> > > > > > As this PR reformat the code with google-java-format v2, it will
> > > likely
> > > > > > caused conflicts on many existed PRs.
> > > > > >
> > > > > > Let us know if any concern before we merge the PR.
> > > > > >
> > > > >
> > >

Reply via email to