I thought all needed was good, and the thing I didn't get right was the @ClassRule, but otherwise I think it is good to go. Or?
On Mon, Feb 27, 2017 at 12:27 AM, Paul Merlin <[email protected]> wrote: > Le 2017-02-26 15:22, [email protected] a écrit : > >> Updated the devstatus for the Cassandra ES. >> >> <!-- none, brief, good, complete --> >> - <documentation>none</documentation> >> + <documentation>good</documentation> >> >> <!-- none, some, good, complete --> >> - <unittests>none</unittests> >> + <unittests>good</unittests> >> > > Now that we have the infrastructure to do integration testing, we should > not flag tests as 'good' when they are not run by the test suite. > We need a docker based test of the new Cassandra ES. > > Here are the steps involved: > - declare which docker image to use in ~/dependencies.gradle (at the > bottom of the file) > - add internals/testsupport-internal/src/main/docker/cassandra/Dockerfile > (see the other Dockerfiles for inspiration) > - depend on polygene.internals.testsupport instead of > polygene.core.testsupport, this provides our JUnit DockerRule > - add the DockerRule and host/port settings to the test (see other docker > based tests for inspiration) > > I'm pushing this also for me not to be the only one knowing how to do this > :) > > Cheers > > /Paul > > -- Niclas Hedhman, Software Developer http://polygene.apache.org <http://zest.apache.org> - New Energy for Java
