On Sat, 29 Aug 2020 at 15:19, sebb <seb...@gmail.com> wrote: > > On Sat, 29 Aug 2020 at 13:51, Daniel Gruno <humbed...@apache.org> wrote: > > > > On 29/08/2020 12.51, sebb wrote: > > > The From headers in the mboxes corpus/maven_dev_2017_* all have the > > > same From line: > > > > > > From TEST@TEST > > > > > > Why is this? > > > > > > Also 'From ' lines are supposed to have a date, so these lines are not > > > valid. > > > > > > > Because they were collated to produce a special mbox for testing against > > the same email from multiple sources. I don't believe TEST@TEST has any > > actual impact on the unit tests. > > Probably not, at least for the DKIM generator. > Other generators may vary. > > Note that the files have got mixed EOLs. > The generated From and trailing blank lines use CRLF, whereas the > message bodies use LF. > > This is not ideal, so it would be sensible to regenerate the output. > > I have fixed the collate tool to use the same trailing EOLs as the > source, and to use the original From lines. > > Are the sources still available to regenerate the output? > > This won't require a change to the yaml files. > [If it does, then it's indicative of a bug.]
I see now that you use the mbox files for dev@maven for Sep to Dec 2017. I have used these to fix the test data. The test still works OK.
