sbp commented on issue #49: URL: https://github.com/apache/incubator-ponymail-foal/issues/49#issuecomment-890341060
The default timeout in the elasticsearch package [is ten seconds](https://github.com/elastic/elasticsearch-py/blob/da42c81fa8d0087099f3a1d22f75ab8b2319c962/elasticsearch/connection/base.py#L79), and foal does not override it. The thread properties code looks up each `in-reply-to` and then each `references` until it finds a value that's in the database. It may then additionally perform one more query if no parent message was found. Instead of setting an overall timeout using a decorator, it may be better to allow the user to configure the timeout for thread property queries, and provide an upper bound on the number of `in-reply-to` and `references` values that will be queried. If no upper bound were given then it would be possible for an attacker to send a message that has thousands of junk values, all of which would be queried. Therefore a reasonable default limit should be placed on values anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
