On Mon, 15 Nov 2021 at 17:13, <[email protected]> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> humbedooh pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/incubator-ponymail-foal.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 24f5b6d  address space confusion
> 24f5b6d is described below
>
> commit 24f5b6d6486f4680d45af9a7575f918b269a6945
> Author: Daniel Gruno <[email protected]>
> AuthorDate: Mon Nov 15 18:13:44 2021 +0100
>
>     address space confusion
> ---
>  server/endpoints/thread.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/server/endpoints/thread.py b/server/endpoints/thread.py
> index 97120b1..3e28123 100644
> --- a/server/endpoints/thread.py
> +++ b/server/endpoints/thread.py
> @@ -26,9 +26,11 @@ import typing
>  async def process(
>      server: plugins.server.BaseServer, session: 
> plugins.session.SessionObject, indata: dict,
>  ) -> typing.Optional[dict]:
> -    email = await plugins.messages.get_email(session, 
> permalink=indata.get("id"))
> +    mailid = indata.get("id")
> +    email = await plugins.messages.get_email(session, permalink=mailid)
>      if not email:
> -        email = await plugins.messages.get_email(session, 
> messageid=indata.get("id"))
> +        mailid = mailid.replace(" ", "+")  # Some Message-IDs have + in 
> them, this can confuse since + means space.

What problem is this change trying to fix?

if it is an HTTP encoding issue it does not seem right to fix it here.

> +        email = await plugins.messages.get_email(session, messageid=mailid)
>      if email and isinstance(email, dict):
>          thread, emails, pdocs = await 
> plugins.messages.fetch_children(session, email, short=True)
>      else:

Reply via email to