sbp commented on code in PR #264: URL: https://github.com/apache/incubator-ponymail-foal/pull/264#discussion_r1711414484
########## tools/import-mbox.py: ########## @@ -166,7 +166,7 @@ def printid(self, message): print("%s: %s" % (self.name, message)) def run(self): - global goodies, baddies, dedupped + global goodies, baddies, dedupped, es Review Comment: If `es` isn't declared as a global here then using `--dedup` without `--dry` breaks because the `es = ...` assignment on L346 makes it a local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ponymail.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org