Hi Stephan,

Stephan Bergmann a écrit :
Hi all,

I suspect that CVS module tools contains quite some dead code for obscure, no-longer used platforms, and I would like to clean this up on CWS warnings01.

I vote for dead code.

  However, in the case of Mac, I am not sure whether some
specific code is still used for OS X builds (and should thus not be removed) or was intended for pre OS X builds (and should thus be removed): 1 In tools/prj/build.lst 1.21, the line for tools\mac\source has an "m"

If I understand correctly your question, actually, we use u (for unix) on Mac OS X.

in the platform column.  Does that mean that it is built on OS X?

No, I think it's old code. Looking at m133 build, I don't see ano .o relative to anything in mac subdirectory. Since we maintain only Mac OS X, IMHO, this code is obsolete. But I'd prefer wait for other opinions.

Tino ? Florian ?

2 In a number of C++ source files (e.g., tools/source/datetime/tdate.cxx 1.2, tools/source/fsys/comdep.cxx 1.2), there is code of the form

  #if defined MAC

Is MAC defined on OS X?

No, I don't think so. MACOSX is used for os building environment variable. Other important are BUILD_OS_MAJOR, BUILD_OS_MINOR, GUIBASE

fa has made a lot of cleanup sometimes ago, and you probably will save time asking him directly ?

I am to young in OOo project to be aware about all these changes  :-)



Regards,
eric bachard


--
<[EMAIL PROTECTED]>
Francophone OpenOffice.org Commmunity developer (Linux PPC / Mac OS X / X11)
See : <http://fr.openoffice.org>


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to