[EMAIL PROTECTED] wrote:
Tag: cws_src680_presfixes09
User: thb Date: 2006/10/19 07:34:04

Modified:
   porting/sal/inc/rtl/math.hxx

Log:
 #142144# Not including the math constants down here is highly fragile, because 
then order of includes matters in upper layers (that sometimes need those 
M_PI_* constants)

File Changes:

Directory: /porting/sal/inc/rtl/
================================

File [changed]: math.hxx
Url: 
http://porting.openoffice.org/source/browse/porting/sal/inc/rtl/math.hxx?r1=1.6&r2=1.6.164.1
Delta lines:  +6 -3
-------------------
--- math.hxx    8 Sep 2005 14:39:47 -0000       1.6
+++ math.hxx    19 Oct 2006 14:34:02 -0000      1.6.164.1
@@ -4,9 +4,9 @@
  *
  *  $RCSfile: math.hxx,v $
  *
- *  $Revision: 1.6 $
+ *  $Revision: 1.6.164.1 $
  *
- *  last change: $Author: rt $ $Date: 2005/09/08 14:39:47 $
+ *  last change: $Author: thb $ $Date: 2006/10/19 14:34:02 $
  *
  *  The Contents of this file are made available subject to
  *  the terms of GNU Lesser General Public License Version 2.1.
@@ -43,6 +43,9 @@
 #include "sal/mathconf.h"
 #include "sal/types.h"
+#ifndef _USE_MATH_DEFINES
+#define  _USE_MATH_DEFINES  // needed by Visual C++ for math constants
+#endif

_USE_MATH_DEFINES appears to be specific to MSC, so I think it would be better to do

  #if defined _MSC_VER && !defined _USE_MATH_DEFINES

instead.

-Stephan

 #include <math.h>
namespace rtl {

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to