Michael, as the QA rep of your choice, I am currently looking at CWS salstrintern :-)
I build it from scratch on a Kubuntu box (Solaris, Windows waiting for tomorrow). So, the good thing, it actually did build. Unfortunately menus and toolbars seem to broken (strings do not get displayed properly), do you have an idea what went wrong?
I also took a brief look at the code, leading to some (may be silly :-) questions / comments: - rtl::OUString::intern currently does return a new string, what about not returning a new string but just interning "this" one? - rtl::OUStrings are unfortunately semantically and by structure similar to the strings implemented in the tools module. rtl::OUStrings and tools strings can be directly casted into each other, while their methods are doubled with slightly different semantics. Taking a look a your patches, it seems, that you did not adapt the tools strings. Did you actually took a look at them and no changes are needed, or did you oversaw the tools strings? - I actually like the SAL_STRING_STATIC stuff :-), it is a generalization of the "empty" string.
That's it for now Kay Michael Meeks wrote: --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
