[
https://issues.apache.org/jira/browse/PIO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664431#comment-16664431
]
ASF GitHub Bot commented on PIO-182:
------------------------------------
takezoe edited a comment on issue #482: [PIO-182] Add async methods to
LEventStore
URL: https://github.com/apache/predictionio/pull/482#issuecomment-433113835
@longliveenduro Even if we use thread for asynchronous processing, we should
use separated thread pools for CPU bound processing and I/O bound processing.
The thread pool for CPU bound processing should have threads close to the
number of CPUs. One for I/O bound processing should have threads significantly
larger than the number of CPUs.
Anyway, I think that allowing to give an execution context from user side is
good strategy because it makes possible to control by users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add asynchronous (non-blocking) methods to LEventStore
> ------------------------------------------------------
>
> Key: PIO-182
> URL: https://issues.apache.org/jira/browse/PIO-182
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.13.0
> Reporter: Naoki Takezoe
> Assignee: Naoki Takezoe
> Priority: Major
>
> The current implementation of {{LEventStore}} has only synchronous (blocking)
> methods. Since they use {{ExecutionContext.Implicit.global}}, its parallelism
> is limited up to the number of processors. This means engine server's
> parallelism is also limited if we use these methods in prediction logic.
> To solve this problem, {{Future}} version of these methods should be added to
> {{LEventStore}} and also current blocking methods should be modified to take
> {{ExecutionContext}} (as an implicit parameter).
> See also:
> https://lists.apache.org/thread.html/f14e4f8f29410e4585b3d8e9f646b88293a605f4716d3c4d60771854@%3Cuser.predictionio.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
