[
https://issues.apache.org/jira/browse/PIO-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690165#comment-16690165
]
ASF GitHub Bot commented on PIO-193:
------------------------------------
takezoe commented on issue #495: [PIO-193] Async support for predict method and
storage access, blocking code wrapped in blocking construct
URL: https://github.com/apache/predictionio/pull/495#issuecomment-439568688
I haven't checked this pull request in details, but first of all, I would
like to discuss about our direction about this topic.
Basically, I agree to introduce asynchronousity in whole predict API process
and I think your pull request is one of good ideas to achive it. Since we
already have Akka-HTTP and async storage access layer, making prediction
service asynchronous makes sense. In addition, if we can do it, we can also
mark `LEventStore`'s blocking methods as deprecated.
> With "nearly" I mean that an engine implementor has to add "override" to
its implementation of predictBase() / predict(), when he recompiles/changes his
engine.
However, I'm not sure if this is acceptable in our backword compatibility
policy. And also we need to update docs and all existing official templates to
use new async APIs if we accept this pull request. It's a big change.
@dszeto What do you think about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use async requests to storage whenever possible
> -----------------------------------------------
>
> Key: PIO-193
> URL: https://issues.apache.org/jira/browse/PIO-193
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.13.0
> Reporter: Chris Wewerka
> Priority: Major
>
> The storage access in Prediction IO uses blocking drivers and uses the
> standard scala ExecutionContext which is a bounded ForkJoin ThreadPool. This
> leads to bad usage of machines resources.
>
> See also
> [https://lists.apache.org/thread.html/f14e4f8f29410e4585b3d8e9f646b88293a605f4716d3c4d60771854@%3Cuser.predictionio.apache.org%3E]
> and https://jira.apache.org/jira/browse/PIO-182
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
