Creating a Jira for a PR is all well and fine but using pathces + Jira is a pretty archaic and cumbersome way to handle PRs. If we simply reopen the PR against the mirror github repo then all conversations there can be sent to dev@ and once the PR is in good shape the committer shepherding the PR can merge from the contributors branch and push to Apache git. No shiny green github merge button but pretty straight-forward.
This is the way we do it in Mahout. It makes best use of Github’s code review GUI and PRs. I think it is similar to Spark since we didn’t invent this method. It is also supported by infra. On Jul 1, 2016, at 2:32 PM, Donald Szeto <[email protected]> wrote: Definitely moving to JIRA. We just want to explain to the community why they are closed, since some of them asked. On Friday, July 1, 2016, Andrew Purtell <[email protected]> wrote: > What about moving all of those PRs, and their changes (as patch) to the new > PIO JIRA instance? > > There is some discussion about allowing GH Issues as a blessed resource for > development workflow, but we are not there yet where there is guidance for > podlings (or even TLPs). > > On Thu, Jun 30, 2016 at 4:04 PM, Pat Ferrel <[email protected] > <javascript:;>> wrote: > >> The way Mahout works is that committers can open or close PRs (though a >> github merge will fail). But I can’t re-poen these PRs. That would be an >> easy solution, right? Maybe someone just needs to grant us certain github >> permissions? >> >> On Jun 30, 2016, at 3:01 PM, Donald Szeto <[email protected] > <javascript:;>> wrote: >> >> But not all PRs are closed, so it left me wondering if there is a set of >> conditions that were triggered when GitHub integration was turned on. >> >> On Thursday, June 30, 2016, Pat Ferrel <[email protected] > <javascript:;>> wrote: >> >>> Maybe I missed the explanation but why are all the gitub PRs against > the >>> PIO account closed? This is not ideas, especially if some should be >> merged >>> with the ASF git, because the PRs have user/branch info that can be > used >> to >>> hand-merge. >>> >>> >> >> > > > -- > Best regards, > > - Andy > > Problems worthy of attack prove their worth by hitting back. - Piet Hein > (via Tom White) >
