Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793046
--- Diff: bin/install.sh ---
@@ -389,16 +409,10 @@ case $source_setup in
${SED_CMD} "s|#
PIO_STORAGE_SOURCES_LOCALFS|PIO_STORAGE_SOURCES_LOCALFS|"
${pio_dir}/conf/pio-env.sh
${SED_CMD} "s|#
PIO_STORAGE_SOURCES_ELASTICSEARCH_TYPE|PIO_STORAGE_SOURCES_ELASTICSEARCH_TYPE|"
${pio_dir}/conf/pio-env.sh
${SED_CMD} "s|#
PIO_STORAGE_SOURCES_ELASTICSEARCH_HOME=.*|PIO_STORAGE_SOURCES_ELASTICSEARCH_HOME=$elasticsearch_dir|"
${pio_dir}/conf/pio-env.sh
-
echo -e "\033[1;32mElasticsearch setup done!\033[0m"
# HBase
echo -e "\033[1;36mStarting HBase setup in:\033[0m $hbase_dir"
- if [[ -e hbase-${HBASE_VERSION}-bin.tar.gz ]]; then
- if confirm "Delete existing hbase-$HBASE_VERSION-bin.tar.gz?"; then
- rm hbase-${HBASE_VERSION}-bin.tar.gz
- fi
- fi
if [[ ! -e hbase-${HBASE_VERSION}-bin.tar.gz ]]; then
echo "Downloading HBase..."
curl -O
http://archive.apache.org/dist/hbase/${HBASE_VERSION}/hbase-${HBASE_VERSION}-bin.tar.gz
--- End diff --
ready for review.
This adds an options that install DBs *and * Elasticsearch and fixes a
couple bugs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
