[ 
https://issues.apache.org/jira/browse/PIO-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436078#comment-15436078
 ] 

ASF GitHub Bot commented on PIO-26:
-----------------------------------

Github user Ziemin commented on a diff in the pull request:

    
https://github.com/apache/incubator-predictionio/pull/279#discussion_r76166941
  
    --- Diff: tests/script.travis.sh ---
    @@ -1,8 +1,27 @@
    -#!/bin/bash -
    +#!/bin/bash
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
     
     set -e
     
     if [[ $BUILD_TYPE == Unit ]]; then
    +  # Run license check
    +  ./tests/check_license.sh
    --- End diff --
    
    I can see that this command might take a while, what may rise some problems 
on travis, if it doesn't produce any output for a couple of minutes. I think 
that we should try to prevent travis from failing because of it. I am writing 
about it, because it takes more than 15 minutes on my computer to finish.


> Integrate Apache RAT for license checking
> -----------------------------------------
>
>                 Key: PIO-26
>                 URL: https://issues.apache.org/jira/browse/PIO-26
>             Project: PredictionIO
>          Issue Type: New Feature
>            Reporter: Chan
>             Fix For: 0.10.0
>
>
> http://creadur.apache.org/rat/
> Use this for Apache license checking 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to