[
https://issues.apache.org/jira/browse/PIO-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438298#comment-15438298
]
Pat Ferrel commented on PIO-28:
-------------------------------
I like the idea of this. Regarding an admin server, it would be nice to factor
out the CLI and provide the functional part of the PIO commands as microservice
so the admin server could drive things via REST controlling multiple Event and
PredictionServers.
This would mean further refactoring and creation of a REST service to perform
all of what the CLI does now. The CLI would then just be a process that
translates the CLI into REST calls. Creating an Admin service does the same but
maybe through a gui and all sides are nicely decoupled. This would allow us to
communicate with multiple EventServers and PredictionServers even using service
discovery to drive it all.
This won't be merged until after the 0.10.0 release, Do you think it fits the
above architecture description?
> Extract logic from functions handling console commands in tools package.
> ------------------------------------------------------------------------
>
> Key: PIO-28
> URL: https://issues.apache.org/jira/browse/PIO-28
> Project: PredictionIO
> Issue Type: Sub-task
> Reporter: Marcin Ziemiński
> Priority: Minor
>
> Currently functions used by Console.scala to handle commands are evaluated
> for side effects - printing logs to the user. They either return integers or
> units and sometimes use sys.exit(1) on failure.
> The actual logic should be extracted from them to some other place for future
> applications, e.g. to be used by admin server, which is not implemented yet.
> Reporting results to the client should be separated from processing
> application logic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
