[ 
https://issues.apache.org/jira/browse/PIO-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105614#comment-16105614
 ] 

ASF GitHub Bot commented on PIO-104:
------------------------------------

Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/407
  
    LGTM. Thanks @takezoe !


> Make proper implementation of plugins
> -------------------------------------
>
>                 Key: PIO-104
>                 URL: https://issues.apache.org/jira/browse/PIO-104
>             Project: PredictionIO
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.11.0-incubating
>            Reporter: Naoki Takezoe
>            Assignee: Naoki Takezoe
>
> The current plugin system has some issues to be fixed:
> - start() method of plugin is not called, this method seems to be unnecessary
> - outputSniffer exists as interface, but it's not implemented in engine server
> We should fix them before documenting plugin usage in PIO-101



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to