2018-11-28 02:42:18 UTC - Rajan Dhabalia: hi @Matteo Merli @Sijie Guo qq regarding bookie write-cache flushing.. in BK-4.3 syncThread used to always flush the write-cache if flush-interval has been configured. but it doesn't seem like the same with bk-4.7. it seems bookie honors flushinterval only if `entryLogPerLedgerEnabled` is eanbled, else it doesn't schedule checkpoint task in bookie so, write-cache gets flushed once cache reached to threshold <https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java#L711>
can you please confirm my understanding.. ---- 2018-11-28 02:48:32 UTC - Sijie Guo: @Rajan Dhabalia yes. ---- 2018-11-28 02:49:33 UTC - Matteo Merli: Uhm, that doesn’t sound correct then, is that the same in master too? ---- 2018-11-28 02:51:30 UTC - Sijie Guo: yes. checkpoint now scheduled when entrylog rotated in both interleaved, and checkpoint scheduled when memtable flushed. ---- 2018-11-28 02:51:58 UTC - Sijie Guo: actually I think db ledger storage is somehow missed ---- 2018-11-28 03:10:40 UTC - Sijie Guo: I think db ledger storage should use the SyncThread as entryLogPerLedgerEnabled ---- 2018-11-28 03:19:17 UTC - Sijie Guo: sending out a PR for it ---- 2018-11-28 03:24:44 UTC - Sijie Guo: actually that should only affect 4.8 and onwards ---- 2018-11-28 03:24:47 UTC - Matteo Merli: :+1: ---- 2018-11-28 03:25:08 UTC - Matteo Merli: Uhm, I think Rajan is testing with 4.7.2 ---- 2018-11-28 03:25:27 UTC - Sijie Guo: double checking ---- 2018-11-28 03:25:56 UTC - Sijie Guo: oh nvm ---- 2018-11-28 03:26:02 UTC - Sijie Guo: it was included in 4.7.0 ---- 2018-11-28 03:26:17 UTC - Sijie Guo: I will send a fix and it should go to 4.7.3 ---- 2018-11-28 03:28:34 UTC - Rajan Dhabalia: Yes, we are on 4.7.2 ---- 2018-11-28 03:28:37 UTC - Rajan Dhabalia: Thanks :+1::skin-tone-2: ---- 2018-11-28 04:19:04 UTC - Sijie Guo: @Rajan Dhabalia @Matteo Merli: <https://github.com/apache/bookkeeper/pull/1843> +1 : Rajan Dhabalia ----
