Jinfeng, Thank you for driving this effort!
Given the tight dependencies between these two communities, I think it is okay to use the coding guide from BookKeeper. A lot of Pulsar committers are also BookKeeper committers. Having a consistent coding guide between two communities would actually help a lot. If there are no objections in the community, we can probably start with that, and iterate it over time. Thanks, Sijie On Wed, Oct 30, 2019 at 10:46 PM Jinfeng Huang <h...@streamnative.io> wrote: > Shall we add a coding guide for Apache Pulsar? Do you have any advice on > it? > For details, refer to https://github.com/apache/pulsar/pull/5494. > > Best Regards, > Jennifer > > > On Tue, Oct 29, 2019 at 11:10 PM Jinfeng Huang <h...@streamnative.io> > wrote: > > > Hi all, > > When our users read the contributing guidelines at > > https://pulsar.apache.org/en/contributing/#code , they found the link > > navigates to coding guide does not work. After investigation, we've found > > there is no coding guide for Apache Pulsar. > > > > Shall we add a coding guide for Apache Pulsar? I've referred to the > coding > > guide of Apache BookKeeper, and drafted one for Apache Pusar at > > https://github.com/apache/pulsar/pull/5494. > > I'm not quite sure about some technical points. Could you please help > some > > guidance on this? Any advice is highly appreciated. > > > > Best Regards, > > Jennifer > > >
